Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[QUIC] Options classes fixes #10828

Merged
merged 12 commits into from
Jan 22, 2025
Merged

[QUIC] Options classes fixes #10828

merged 12 commits into from
Jan 22, 2025

Conversation

ManickaP
Copy link
Member

Fixing some details while working on: dotnet/docs#44212

@learn-build-service-prod Learn Build Service (PROD)

This comment was marked as outdated.

Sign in to view
@learn-build-service-prod Learn Build Service (PROD)

This comment was marked as outdated.

Sign in to view
@ManickaP ManickaP marked this pull request as ready for review January 17, 2025 11:41
@ManickaP ManickaP requested a review from a team as a code owner January 17, 2025 11:41
@ManickaP ManickaP requested a review from a team as a code owner January 20, 2025 16:42
@learn-build-service-prod Learn Build Service (PROD)

This comment was marked as outdated.

Sign in to view
@learn-build-service-prod Learn Build Service (PROD)
Copy link

Learn Build status updates of commit b046acc:

✅ Validation status: passed

File Status Preview URL Details
xml/ns-System.Net.Quic.Implementations.xml ✅Succeeded n/a (file deleted or renamed)
xml/ns-System.Net.Quic.xml ✅Succeeded View
xml/System.Net.Quic/QuicClientConnectionOptions.xml ✅Succeeded View
xml/System.Net.Quic/QuicConnection.xml ✅Succeeded View
xml/System.Net.Quic/QuicConnectionOptions.xml ✅Succeeded View
xml/System.Net.Quic/QuicListener.xml ✅Succeeded View
xml/System.Net.Quic/QuicListenerOptions.xml ✅Succeeded View
xml/System.Net.Quic/QuicReceiveWindowSizes.xml ✅Succeeded View
xml/System.Net.Quic/QuicServerConnectionOptions.xml ✅Succeeded View
xml/System.Net.Quic/QuicStream.xml ✅Succeeded View

For more details, please refer to the build report.

For any questions, please:

@ManickaP ManickaP requested a review from gewarren January 21, 2025 14:38
CarnaViire
CarnaViire approved these changes Jan 21, 2025
View reviewed changes
Copy link
Member

@CarnaViire CarnaViire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

gewarren
gewarren approved these changes Jan 21, 2025
View reviewed changes
xml/System.Net.Quic/QuicClientConnectionOptions.xml Outdated Show resolved Hide resolved
xml/System.Net.Quic/QuicConnection.xml Outdated Show resolved Hide resolved
xml/System.Net.Quic/QuicConnectionOptions.xml Outdated Show resolved Hide resolved
xml/System.Net.Quic/QuicConnectionOptions.xml Outdated Show resolved Hide resolved
xml/System.Net.Quic/QuicConnectionOptions.xml Outdated Show resolved Hide resolved
xml/System.Net.Quic/QuicListenerOptions.xml Outdated Show resolved Hide resolved
xml/System.Net.Quic/QuicListenerOptions.xml Outdated Show resolved Hide resolved
xml/System.Net.Quic/QuicServerConnectionOptions.xml Outdated Show resolved Hide resolved
xml/System.Net.Quic/QuicStream.xml Outdated Show resolved Hide resolved
xml/ns-System.Net.Quic.xml Outdated Show resolved Hide resolved
@learn-build-service-prod Learn Build Service (PROD)
Copy link

Learn Build status updates of commit 6a63806:

✅ Validation status: passed

File Status Preview URL Details
xml/ns-System.Net.Quic.Implementations.xml ✅Succeeded n/a (file deleted or renamed)
xml/ns-System.Net.Quic.xml ✅Succeeded View
xml/System.Net.Quic/QuicClientConnectionOptions.xml ✅Succeeded View
xml/System.Net.Quic/QuicConnection.xml ✅Succeeded View
xml/System.Net.Quic/QuicConnectionOptions.xml ✅Succeeded View
xml/System.Net.Quic/QuicListener.xml ✅Succeeded View
xml/System.Net.Quic/QuicListenerOptions.xml ✅Succeeded View
xml/System.Net.Quic/QuicReceiveWindowSizes.xml ✅Succeeded View
xml/System.Net.Quic/QuicServerConnectionOptions.xml ✅Succeeded View
xml/System.Net.Quic/QuicStream.xml ✅Succeeded View

For more details, please refer to the build report.

For any questions, please:

@learn-build-service-prod Learn Build Service (PROD)
Copy link

Learn Build status updates of commit 23e4143:

✅ Validation status: passed

File Status Preview URL Details
xml/ns-System.Net.Quic.Implementations.xml ✅Succeeded n/a (file deleted or renamed)
xml/ns-System.Net.Quic.xml ✅Succeeded View
xml/System.Net.Quic/QuicClientConnectionOptions.xml ✅Succeeded View
xml/System.Net.Quic/QuicConnection.xml ✅Succeeded View
xml/System.Net.Quic/QuicConnectionOptions.xml ✅Succeeded View
xml/System.Net.Quic/QuicListener.xml ✅Succeeded View
xml/System.Net.Quic/QuicListenerOptions.xml ✅Succeeded View
xml/System.Net.Quic/QuicReceiveWindowSizes.xml ✅Succeeded View
xml/System.Net.Quic/QuicServerConnectionOptions.xml ✅Succeeded View
xml/System.Net.Quic/QuicStream.xml ✅Succeeded View

For more details, please refer to the build report.

For any questions, please:

@ManickaP ManickaP merged commit b1dc5b4 into dotnet:main Jan 22, 2025
4 checks passed
@ManickaP ManickaP deleted the quic-options branch January 22, 2025 09:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gewarren gewarren gewarren approved these changes

@CarnaViire CarnaViire CarnaViire approved these changes

Assignees

@ManickaP ManickaP

Labels
area-System.Net
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ManickaP @CarnaViire @gewarren