Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add example for optional attr #9355

Merged

Conversation

Rageking8
Copy link
Contributor

Summary

Add an example for usage of OptionalAttribute.

@ghost ghost added the community-contribution Indicates that the PR has been added by a community member label Oct 2, 2023
@learn-build-service-prod
Copy link

Learn Build status updates of commit a2393a3:

✅ Validation status: passed

File Status Preview URL Details
snippets/csharp/System.Runtime.InteropServices/OptionalAttribute/Overview/Project.csproj ✅Succeeded
snippets/csharp/System.Runtime.InteropServices/OptionalAttribute/Overview/sample.cs ✅Succeeded View
xml/System.Runtime.InteropServices/OptionalAttribute.xml ✅Succeeded View

For more details, please refer to the build report.

For any questions, please:

Copy link
Contributor

@gewarren gewarren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Rageking8. Just some whitespace cleanup suggestions (the weird indentation and trailing spaces are a relic from long ago).

xml/System.Runtime.InteropServices/OptionalAttribute.xml Outdated Show resolved Hide resolved
xml/System.Runtime.InteropServices/OptionalAttribute.xml Outdated Show resolved Hide resolved
xml/System.Runtime.InteropServices/OptionalAttribute.xml Outdated Show resolved Hide resolved
xml/System.Runtime.InteropServices/OptionalAttribute.xml Outdated Show resolved Hide resolved
xml/System.Runtime.InteropServices/OptionalAttribute.xml Outdated Show resolved Hide resolved
xml/System.Runtime.InteropServices/OptionalAttribute.xml Outdated Show resolved Hide resolved
Co-authored-by: Genevieve Warren <[email protected]>
@Rageking8
Copy link
Contributor Author

@gewarren Thanks for the quick review, applied all the space cleanups suggested!

@learn-build-service-prod
Copy link

Learn Build status updates of commit 10552d9:

✅ Validation status: passed

File Status Preview URL Details
snippets/csharp/System.Runtime.InteropServices/OptionalAttribute/Overview/Project.csproj ✅Succeeded
snippets/csharp/System.Runtime.InteropServices/OptionalAttribute/Overview/sample.cs ✅Succeeded View
xml/System.Runtime.InteropServices/OptionalAttribute.xml ✅Succeeded View

For more details, please refer to the build report.

For any questions, please:

@Rageking8
Copy link
Contributor Author

@jkoritzinsky Gentle ping for review.

@AaronRobinsonMSFT AaronRobinsonMSFT merged commit 05d4f99 into dotnet:main Oct 23, 2023
1 check passed
@Rageking8 Rageking8 deleted the add-example-for-optional-attr branch November 3, 2023 08:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-System.Runtime.InteropServices community-contribution Indicates that the PR has been added by a community member
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants