Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix typos in property names and comments #9441

Merged
merged 5 commits into from
Nov 17, 2023
Merged

Fix typos in property names and comments #9441

merged 5 commits into from
Nov 17, 2023

Conversation

JoanGil
Copy link
Contributor

@JoanGil JoanGil commented Nov 9, 2023

Summary

Fix typos in property names and comments:

From propety ❌ to property ✅

@JoanGil JoanGil requested a review from a team as a code owner November 9, 2023 10:35
@ghost ghost added the community-contribution Indicates that the PR has been added by a community member label Nov 9, 2023
@dotnet-issue-labeler dotnet-issue-labeler bot added the needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners label Nov 9, 2023
@dotnet-issue-labeler dotnet-issue-labeler
Copy link

I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label.

@learn-build-service-prod Learn Build Service (PROD)
Copy link

Learn Build status updates of commit 9a58c3c:

✅ Validation status: passed

File Status Preview URL Details
snippets/cpp/VS_Snippets_CLR/Type_GetProperty2/CPP/type_getproperty2.cpp ✅Succeeded View
snippets/csharp/System.Windows.Input/CanExecuteRoutedEventArgs/Parameter/Window1.xaml.cs ✅Succeeded View
snippets/csharp/System.Windows.Threading/Dispatcher/Invoke/Window1.xaml.cs ✅Succeeded View
snippets/csharp/System/Type/GetProperty/type_getproperty2.cs ✅Succeeded View
snippets/fsharp/System/Type/GetProperty/type_getproperty2.fs ✅Succeeded View
snippets/visualbasic/VS_Snippets_CLR/Type_GetProperty1/VB/type_getproperty1.vb ✅Succeeded View
snippets/visualbasic/VS_Snippets_Wpf/InvalidateRequeryWithDispatcherTimer/visualbasic/window1.xaml.vb ✅Succeeded View
snippets/visualbasic/VS_Snippets_Wpf/InvalidateRequeryWithSystemTimer/visualbasic/window1.xaml.vb ✅Succeeded View

For more details, please refer to the build report.

For any questions, please:

gewarren
gewarren reviewed Nov 9, 2023
View reviewed changes
Copy link
Contributor

@gewarren gewarren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @JoanGil. I know your changes don't affect compilation, but could you add the missing C# and VB project files so we can check compilation (don't worry about the C++ one)?

@JoanGil
Copy link
Contributor Author

JoanGil commented Nov 9, 2023

What do you mean by "adding the project files"? If you could give me more context or an example I would gladly do it!

@gewarren
Copy link
Contributor

gewarren commented Nov 9, 2023

What do you mean by "adding the project files"? If you could give me more context or an example I would gladly do it!

Just adding a simple project file like this to the following folders:

  • snippets/csharp/System/Type/GetProperty
  • snippets/visualbasic/VS_Snippets_CLR/Type_GetProperty1/VB

Thank you @JoanGil!

@JoanGil
Add project files to check compilation
db40a0c 
Adding a project file to the following folders:

snippets/csharp/System/Type/GetProperty
snippets/visualbasic/VS_Snippets_CLR/Type_GetProperty1/VB
@JoanGil
Copy link
Contributor Author

JoanGil commented Nov 10, 2023

Done @gewarren!

Question: For the future, how do I know to what folders do I have to add a project file so it compiles? Thanks!

@learn-build-service-prod Learn Build Service (PROD)
Copy link

Learn Build status updates of commit db40a0c:

✅ Validation status: passed

File Status Preview URL Details
snippets/cpp/VS_Snippets_CLR/Type_GetProperty2/CPP/type_getproperty2.cpp ✅Succeeded View
snippets/csharp/System.Windows.Input/CanExecuteRoutedEventArgs/Parameter/Window1.xaml.cs ✅Succeeded View
snippets/csharp/System.Windows.Threading/Dispatcher/Invoke/Window1.xaml.cs ✅Succeeded View
snippets/csharp/System/Type/GetProperty/Project.csproj ✅Succeeded
snippets/csharp/System/Type/GetProperty/type_getproperty2.cs ✅Succeeded View
snippets/fsharp/System/Type/GetProperty/type_getproperty2.fs ✅Succeeded View
snippets/visualbasic/VS_Snippets_CLR/Type_GetProperty1/VB/Project.csproj ✅Succeeded
snippets/visualbasic/VS_Snippets_CLR/Type_GetProperty1/VB/type_getproperty1.vb ✅Succeeded View
snippets/visualbasic/VS_Snippets_Wpf/InvalidateRequeryWithDispatcherTimer/visualbasic/window1.xaml.vb ✅Succeeded View
snippets/visualbasic/VS_Snippets_Wpf/InvalidateRequeryWithSystemTimer/visualbasic/window1.xaml.vb ✅Succeeded View

For more details, please refer to the build report.

For any questions, please:

@learn-build-service-prod Learn Build Service (PROD)
Copy link

Learn Build status updates of commit 293de00:

✅ Validation status: passed

File Status Preview URL Details
snippets/cpp/VS_Snippets_CLR/Type_GetProperty2/CPP/type_getproperty2.cpp ✅Succeeded View
snippets/csharp/System.Windows.Input/CanExecuteRoutedEventArgs/Parameter/Window1.xaml.cs ✅Succeeded View
snippets/csharp/System.Windows.Threading/Dispatcher/Invoke/Window1.xaml.cs ✅Succeeded View
snippets/csharp/System/Type/GetProperty/Project.csproj ✅Succeeded
snippets/csharp/System/Type/GetProperty/type_getproperty2.cs ✅Succeeded View
snippets/fsharp/System/Type/GetProperty/type_getproperty2.fs ✅Succeeded View
snippets/visualbasic/VS_Snippets_CLR/Type_GetProperty1/VB/Project.vbproj ✅Succeeded
snippets/visualbasic/VS_Snippets_CLR/Type_GetProperty1/VB/type_getproperty1.vb ✅Succeeded View
snippets/visualbasic/VS_Snippets_Wpf/InvalidateRequeryWithDispatcherTimer/visualbasic/window1.xaml.vb ✅Succeeded View
snippets/visualbasic/VS_Snippets_Wpf/InvalidateRequeryWithSystemTimer/visualbasic/window1.xaml.vb ✅Succeeded View

For more details, please refer to the build report.

For any questions, please:

@gewarren
Copy link
Contributor

Done @gewarren!

Question: For the future, how do I know to what folders do I have to add a project file so it compiles? Thanks!

If you look at the Files changed tab, you can see where there are Snippets 5000 errors. Now there are a few more since we added the projects - looks like we need to provide unique names within the project. I know this is a lot of work just for fixing a spelling mistake, so if you can't get to these, I can do it.

@JoanGil
Copy link
Contributor Author

JoanGil commented Nov 10, 2023

If you look at the Files changed tab, you can see where there are Snippets 5000 errors. Now there are a few more since we added the projects - looks like we need to provide unique names within the project. I know this is a lot of work just for fixing a spelling mistake, so if you can't get to these, I can do it.

Now I see that there are multiple errors when you compile that csproj. The thing is, would that be okay if I put names like: MyClass3, MyTypeClass3... It's not nice but it will solve the compiling problem. If that's okay, I can do the changes myself.

@gewarren
Copy link
Contributor

If you look at the Files changed tab, you can see where there are Snippets 5000 errors. Now there are a few more since we added the projects - looks like we need to provide unique names within the project. I know this is a lot of work just for fixing a spelling mistake, so if you can't get to these, I can do it.

Now I see that there are multiple errors when you compile that csproj. The thing is, would that be okay if I put names like: MyClass3, MyTypeClass3... It's not nice but it will solve the compiling problem. If that's okay, I can do the changes myself.

Yes, that's totally fine. Thanks!

@JoanGil
Copy link
Contributor Author

JoanGil commented Nov 12, 2023

Okay, I have updated the names and now the CSharp files compile. It just fails for the C++ project missing.

Is everything done in my end, right? If not, let me know if I can do something else!

@learn-build-service-prod Learn Build Service (PROD)
Copy link

Learn Build status updates of commit a312b42:

✅ Validation status: passed

File Status Preview URL Details
snippets/cpp/VS_Snippets_CLR/Type_GetProperty2/CPP/type_getproperty2.cpp ✅Succeeded View
snippets/csharp/System.Windows.Input/CanExecuteRoutedEventArgs/Parameter/Window1.xaml.cs ✅Succeeded View
snippets/csharp/System.Windows.Threading/Dispatcher/Invoke/Window1.xaml.cs ✅Succeeded View
snippets/csharp/System/Type/GetProperty/Project.csproj ✅Succeeded
snippets/csharp/System/Type/GetProperty/type_getproperty_types.cs ✅Succeeded View
snippets/csharp/System/Type/GetProperty/type_getproperty1.cs ✅Succeeded View
snippets/csharp/System/Type/GetProperty/type_getproperty2.cs ✅Succeeded View
snippets/csharp/System/Type/GetProperty/type_getproperty21.cs ✅Succeeded View
snippets/csharp/System/Type/GetProperty/type_getproperty3.cs ✅Succeeded View
snippets/fsharp/System/Type/GetProperty/type_getproperty2.fs ✅Succeeded View
snippets/visualbasic/VS_Snippets_CLR/Type_GetProperty1/VB/Project.vbproj ✅Succeeded
snippets/visualbasic/VS_Snippets_CLR/Type_GetProperty1/VB/type_getproperty1.vb ✅Succeeded View
snippets/visualbasic/VS_Snippets_Wpf/InvalidateRequeryWithDispatcherTimer/visualbasic/window1.xaml.vb ✅Succeeded View
snippets/visualbasic/VS_Snippets_Wpf/InvalidateRequeryWithSystemTimer/visualbasic/window1.xaml.vb ✅Succeeded View

For more details, please refer to the build report.

For any questions, please:

@JoanGil
Copy link
Contributor Author

JoanGil commented Nov 17, 2023

Any progress on this one? 😄

@JoanGil JoanGil mentioned this pull request Nov 17, 2023
Merged
@gewarren gewarren enabled auto-merge (squash) November 17, 2023 18:10
@learn-build-service-prod Learn Build Service (PROD)
Copy link

Learn Build status updates of commit d07feeb:

✅ Validation status: passed

File Status Preview URL Details
snippets/cpp/VS_Snippets_CLR/Type_GetProperty2/CPP/type_getproperty2.cpp ✅Succeeded View
snippets/csharp/System.Windows.Input/CanExecuteRoutedEventArgs/Parameter/Window1.xaml.cs ✅Succeeded View
snippets/csharp/System.Windows.Threading/Dispatcher/Invoke/Window1.xaml.cs ✅Succeeded View
snippets/csharp/System/Type/GetProperty/Project.csproj ✅Succeeded
snippets/csharp/System/Type/GetProperty/type_getproperty_types.cs ✅Succeeded View
snippets/csharp/System/Type/GetProperty/type_getproperty1.cs ✅Succeeded View
snippets/csharp/System/Type/GetProperty/type_getproperty2.cs ✅Succeeded View
snippets/csharp/System/Type/GetProperty/type_getproperty21.cs ✅Succeeded View
snippets/csharp/System/Type/GetProperty/type_getproperty3.cs ✅Succeeded View
snippets/fsharp/System/Type/GetProperty/type_getproperty2.fs ✅Succeeded View
snippets/visualbasic/VS_Snippets_CLR/Type_GetProperty1/VB/Project.vbproj ✅Succeeded
snippets/visualbasic/VS_Snippets_CLR/Type_GetProperty1/VB/type_getproperty1.vb ✅Succeeded View
snippets/visualbasic/VS_Snippets_Wpf/InvalidateRequeryWithDispatcherTimer/visualbasic/window1.xaml.vb ✅Succeeded View
snippets/visualbasic/VS_Snippets_Wpf/InvalidateRequeryWithSystemTimer/visualbasic/window1.xaml.vb ✅Succeeded View

For more details, please refer to the build report.

For any questions, please:

@gewarren gewarren merged commit 13edf8e into dotnet:main Nov 17, 2023
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gewarren gewarren gewarren approved these changes

Assignees
No one assigned
Labels
community-contribution Indicates that the PR has been added by a community member needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JoanGil @gewarren