CI Update - .NET 8 GA core libraries #9457
Conversation
Build.Reason:Manual by Genevieve Warren Build.Url:https://apidrop.visualstudio.com/Content%20CI/_build/results?buildId=398016&view=results source_repo.branch:net8-core source_repo.url:https://apidrop.visualstudio.com/_git/binaries
gewarren
requested review from
AaronRobinsonMSFT,
jkoritzinsky and
a team
as code owners
ghost
assigned 
dotnet-issue-labeler
bot
added
the
area-Meta
This comment was marked as outdated.
This comment was marked as outdated.
xml/System.Numerics/Complex.xml
Outdated
| @@ -6983,8 +6983,7 @@ Languages that support custom operators can use the <xref:System.Numerics.Comple | |||
| <MemberSignature Language="F#" Value="abstract member TryFormat : Span<byte> * int * ReadOnlySpan<char> * IFormatProvider -> bool
override this.TryFormat : Span<byte> * int * ReadOnlySpan<char> * IFormatProvider -> bool" Usage="complex.TryFormat (utf8Destination, bytesWritten, format, provider)" /> | |||
| <MemberType>Method</MemberType> | |||
| <Implements> | |||
| <InterfaceMember>M:System.Numerics.INumberBase`1.TryFormat(System.Span{System.Byte},System.Int32@,System.ReadOnlySpan{System.Char},System.IFormatProvider)</InterfaceMember> | |||
| <InterfaceMember>M:System.IUtf8SpanFormattable.TryFormat(System.Span{System.Byte},System.Int32@,System.ReadOnlySpan{System.Char},System.IFormatProvider)</InterfaceMember> | |||
| <InterfaceMember>M:System.Numerics.INumberBase`1.System#IUtf8SpanFormattable#TryFormat(System.Span{System.Byte},System.Int32@,System.ReadOnlySpan{System.Char},System.IFormatProvider)</InterfaceMember> | |||
There was a problem hiding this comment.
@huangmin-ms This line is causing the following warning:
Line 0: [Warning] Cross reference not found: 'System.Numerics.INumberBase`1.System'.
This seems like a bug. I'm not sure where INumberBase`1 comes into play here?
There was a problem hiding this comment.
@gewarren Actually this diff is expected. It was caused by TryFormat method of INumberBase changed from a normal method to an EII member which I can tell from the System.Runtime.dll of net-8.0 in master branch.
In net8-core branch, it is an EII.
Sometimes it would be confused when both of the inherited interfaces INumberBase and IUtf8SpanFormattable have the same method TryFormat(). But from the reflection metadata:
The original inherit chain is: Complex.TryFormat() -> INumberBase.TryFormat() -> IUtf8SpanFormattable.TryFormat()
And now becomes: Complex.TryFormat() -> INumberBase.IUtf8SpanFormattable.TryFormat()
The reason why you see the xref warning is because there are multiple #s in EII signature and currently our build system is not able to handle that character properly.
I logged a bug https://ceapex.visualstudio.com/Engineering/_workitems/edit/926457 to track this issue.
Is this warning a blocking issue for this PR to get merged? or we can ignore it for now?
There was a problem hiding this comment.
@tannergooding Is this what you'd expect to see here, i.e. that Complex.TryFormat() implements INumberBase<T>.IUtf8SpanFormattable.TryFormat() and not IUtf8SpanFormattable.TryFormat()?
There was a problem hiding this comment.
@gewarren Convert # to %23 in xml file will be overwritten in next pipeline run. We will escape it in Ecma2Yaml tool.
This comment was marked as outdated.
This comment was marked as outdated.
Build.Reason:Manual by Genevieve Warren
Build.Url:https://apidrop.visualstudio.com/Content%20CI/_build/results?buildId=398016&view=results
source_repo.branch:net8-core
source_repo.url:https://apidrop.visualstudio.com/_git/binaries