Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update INumberBase`1.xml #9468

Merged
merged 2 commits into from
Nov 20, 2023
Merged

Update INumberBase`1.xml #9468

merged 2 commits into from
Nov 20, 2023

Conversation

sejo6549
Copy link
Contributor

@sejo6549 sejo6549 commented Nov 17, 2023

Changed the MinMagnitude description to properly reflect what it does

Summary

The documentation for MinMagnitude implied that it returned the minimum of x and y. This was changed to reflect that it is the number with the smaller absolute value that is returned

Fixes dotnet/runtime#94500

Changed the MinMagnitude description to properly reflect what it does
@sejo6549 sejo6549 requested a review from a team as a code owner November 17, 2023 21:08
@ghost ghost added the community-contribution Indicates that the PR has been added by a community member label Nov 17, 2023
Copy link
Contributor

@gewarren gewarren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @sejo6549

@gewarren
Copy link
Contributor

@sejo6549 Can you also update MaxMagnitude?

The description for MaxMagnitude was incorrect. This changes the description to properly reflect what it does.
@sejo6549
Copy link
Contributor Author

@sejo6549 Can you also update MaxMagnitude?

Done! It should have the right description now

@sejo6549 sejo6549 closed this Nov 19, 2023
@sejo6549 sejo6549 reopened this Nov 19, 2023

This comment was marked as outdated.

Copy link

Learn Build status updates of commit 2496823:

✅ Validation status: passed

File Status Preview URL Details
xml/System.Numerics/INumberBase`1.xml ✅Succeeded View

For more details, please refer to the build report.

For any questions, please:

@gewarren gewarren merged commit f542249 into dotnet:main Nov 20, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
community-contribution Indicates that the PR has been added by a community member
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Docs and XML comments for Min/MaxMagnitude are incorrect
2 participants