Remove timestamp tags and update readme #1178
Conversation
|
This also fixes dotnet/docker-tools#1102. Can you log a follow up issue to remove the commit SHA and timestamp variable support from Image Builder? |
|
|
||
| 2. Validate the changes locally by running [build.ps1](./build.ps1). It is strongly suggested to specify the `-DockerfilePath` option to avoid the overhead of building all the images. | ||
| 2. Validate the changes locally by running [build.ps1](./build.ps1). | ||
| It is strongly suggested to specify the `-DockerfilePath` option to avoid the overhead of building all the images. |
There was a problem hiding this comment.
We should also have something about how to handle image hierarchies. A lot of people work with the cross Dockerfiles that have multiple Dockerfiles associated with the hierarchy. It would be helpful to provide some guidance on how to determine which Dockerfiles need to be built and how.
There was a problem hiding this comment.
Fair point. I am going to handle this in a follow-up PR. In hindsight it was a mistake to include anything outside of the bare minimum readme updates related to the timestamp removal. Every PR update is wasting a massive amount of compute.
Co-authored-by: Matt Thalman <[email protected]>
|
Admin merging since the last change was readme only changes and the previous run was green. No sense in rebuilding every image in the repo. |
Fixes #1169
Related to #1168