Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[TINY/CLEANUP] also removing comments referencing the issue 31917 #34976

Closed
wants to merge 1 commit into from
Closed

[TINY/CLEANUP] also removing comments referencing the issue 31917 #34976

wants to merge 1 commit into from

Conversation

maumar
Copy link
Contributor

@maumar maumar commented Oct 25, 2024

No description provided.

@maumar maumar enabled auto-merge (squash) October 25, 2024 01:53
@maumar maumar requested a review from a team October 25, 2024 01:53
@roji roji disabled auto-merge October 25, 2024 10:02
roji
roji approved these changes Oct 25, 2024
View reviewed changes
Copy link
Member

@roji roji left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd personally leave these issue references - they gon't hurt, and can be useful when looking at the tests, to reference the relevant bugs/discussions that are related to it...

But approving in case you feel strongly and want to remove.

@maumar
Copy link
Contributor Author

maumar commented Oct 25, 2024

no strong feelings from my side, closing ;)

@maumar maumar closed this Oct 25, 2024
@roji roji deleted the cleanup_of_a_cleanup branch October 25, 2024 11:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@roji roji roji approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@maumar @roji