Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding Half type support for SqlLite #35328

Open
wants to merge 7 commits into
base: main
Choose a base branch
from
Open

Adding Half type support for SqlLite #35328

wants to merge 7 commits into from

Conversation

newmasterSG
Copy link

  • I've read the guidelines for contributing and seen the walkthrough
  • I've posted a comment on an issue with a detailed description of how I am planning to contribute and got approval from a member of the team
  • [x ] The code builds and tests pass locally (also verified by our automated build checks)
  • [x ] Commit messages follow this format:
        Summary of the changes
        - Adding half type mapping for sql lite and double to half convertor.

Fixes #30931

  • [ x] Tests for the changes have been added (for bug fixes / features)
  • [x ] Code follows the same patterns and style as existing code in this repo

Also I want to discuss with team, what shall I change in migration and compiled models, because I a little bit misunderstanding

@newmasterSG newmasterSG requested a review from a team as a code owner December 13, 2024 13:47
cincuranet
cincuranet requested changes Dec 17, 2024
View reviewed changes
src/EFCore.Relational/Storage/HalfTypeMapping.cs Outdated Show resolved Hide resolved
src/EFCore.Sqlite.Core/Storage/Internal/SqlliteHalfTypeMapping.cs Outdated Show resolved Hide resolved
src/EFCore/Storage/ValueConversion/DoubleToHalfConverter.cs Outdated Show resolved Hide resolved
src/EFCore/Storage/ValueConversion/DoubleToHalfConverter.cs Outdated Show resolved Hide resolved
src/EFCore.Sqlite.Core/Storage/Internal/SqlliteHalfTypeMapping.cs Outdated
/// doing so can result in application failures when updating to a new Entity Framework Core release.
/// </summary>
protected override string GenerateNonNullSqlLiteral(object value)
=> new DoubleTypeMapping(StoreType).GenerateSqlLiteral((double)(Half)value);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this needs specific implementation.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What did you mean specific? If value is null, this will generate an exception?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I mean not relying on DoubleTypeMapping, but rather having specific implementation here.

src/EFCore.Relational/Storage/HalfTypeMapping.cs
/// </summary>
public HalfTypeMapping(
string storeType,
DbType? dbType = System.Data.DbType.Single)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

System.Data.DbType.Single is not correct here. Given that there's no Half in System.Data.DbType, I think we can have just specific implementation for SQLite.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Something like new("Real")?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No. I think the HalfTypeMapping should not exist. Simply remove it and have only SQLite implementation.

src/EFCore/Storage/ValueConversion/DoubleToHalfConverter.cs Outdated Show resolved Hide resolved
test/EFCore.Sqlite.Tests/Storage/SqliteTypeMappingSourceTest.cs Outdated
@@ -176,6 +177,7 @@ public void Does_mappings_for_store_type(string storeType, Type clrType, DbType?
[InlineData("REAL", typeof(float), DbType.Single)]
[InlineData("UNREALISTIC", typeof(float), DbType.Single)]
[InlineData("RUBBISH", typeof(float), DbType.Single)]
[InlineData("RUBBISH", typeof(Half?), DbType.Single)]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like you're missing some values here for completeness.

@newmasterSG
Copy link
Author

Sorry for taking so long to respond

cincuranet
cincuranet requested changes Jan 7, 2025
View reviewed changes
src/EFCore.Relational/Storage/HalfTypeMapping.cs
/// </summary>
public HalfTypeMapping(
string storeType,
DbType? dbType = System.Data.DbType.Single)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No. I think the HalfTypeMapping should not exist. Simply remove it and have only SQLite implementation.

test/EFCore.Sqlite.Tests/Storage/SqliteTypeMappingTest.cs
@@ -72,6 +72,7 @@ protected override DbCommand CreateTestCommand()
[InlineData(typeof(SqliteDecimalTypeMapping), typeof(decimal))]
[InlineData(typeof(SqliteGuidTypeMapping), typeof(Guid))]
[InlineData(typeof(SqliteULongTypeMapping), typeof(ulong))]
[InlineData(typeof(EntityFrameworkCore.Sqlite.Storage.Internal.SqliteHalfTypeMapping), typeof(Half))]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Full namespace not needed.

src/EFCore.Sqlite.Core/Storage/Internal/SqlliteHalfTypeMapping.cs Outdated
/// doing so can result in application failures when updating to a new Entity Framework Core release.
/// </summary>
protected override string GenerateNonNullSqlLiteral(object value)
=> new DoubleTypeMapping(StoreType).GenerateSqlLiteral((double)(Half)value);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I mean not relying on DoubleTypeMapping, but rather having specific implementation here.

test/EFCore.Sqlite.Tests/Storage/SqliteTypeMappingSourceTest.cs
@@ -50,6 +50,7 @@ public class SqliteTypeMappingSourceTest : RelationalTypeMappingSourceTestBase
[InlineData("TEXT", typeof(TimeSpan?), DbType.Time)]
[InlineData("TEXT", typeof(decimal?), DbType.Decimal)]
[InlineData("REAL", typeof(float?), DbType.Single)]
[InlineData("REAL", typeof(Half), DbType.Single)]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
[InlineData("REAL", typeof(Half), DbType.Single)]
[InlineData("REAL", typeof(Half?), DbType.Single)]

test/EFCore.Sqlite.Tests/Storage/SqliteTypeMappingSourceTest.cs
@@ -176,6 +177,7 @@ public void Does_mappings_for_store_type(string storeType, Type clrType, DbType?
[InlineData("REAL", typeof(float), DbType.Single)]
[InlineData("UNREALISTIC", typeof(float), DbType.Single)]
[InlineData("RUBBISH", typeof(float), DbType.Single)]
[InlineData("RUBBISH", typeof(Half), DbType.Single)]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still missing i.e. UNREALISTIC case.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cincuranet cincuranet cincuranet requested changes

Requested changes must be addressed to merge this pull request.

Assignees

@cincuranet cincuranet

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Microsoft.Data.Sqlite: Support Half
2 participants
@newmasterSG @cincuranet