Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make SnapshotModelProcessor idempotent. #35432

Merged
merged 1 commit into from
Jan 11, 2025
Merged

Make SnapshotModelProcessor idempotent. #35432

merged 1 commit into from
Jan 11, 2025

Conversation

AndriySvyryd
Copy link
Member

Fixes #35146

@AndriySvyryd AndriySvyryd requested a review from a team as a code owner January 8, 2025 00:33
@SamMonoRT SamMonoRT requested a review from Copilot January 8, 2025 15:23
Copilot
Copilot AI reviewed Jan 8, 2025
View reviewed changes

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

Comments suppressed due to low confidence (1)

src/EFCore.Design/Migrations/Internal/SnapshotModelProcessor.cs:56

  • The variable 'mutableModel' is declared twice in the method, which is redundant. It should be declared only once.
|| model is not Model mutableModel
@AndriySvyryd AndriySvyryd mentioned this pull request Jan 8, 2025
Closed
@AndriySvyryd AndriySvyryd merged commit 0716f70 into main Jan 11, 2025
7 checks passed
@AndriySvyryd AndriySvyryd deleted the Issue35146 branch January 11, 2025 01:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

Copilot Copilot left review comments

@maumar maumar maumar approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Programmatic Scaffold-Migration Issue After Updating to 9.0.0
2 participants
@AndriySvyryd @maumar