Fix NativeAOT warnings on comparers. #35441
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.
roji
reviewed
Jan 9, 2025
| public class GeometryValueComparer | ||
| <[DynamicallyAccessedMembers( | ||
| DynamicallyAccessedMemberTypes.PublicMethods | ||
| | DynamicallyAccessedMemberTypes.NonPublicMethods |
There was a problem hiding this comment.
Am curious, why are non-public methods needed?
There was a problem hiding this comment.
It's what the base class defines and hence needs to be specified also downstream.
There was a problem hiding this comment.
Could we remove it on the base?
There was a problem hiding this comment.
Yeah, agreed - if we're doing work on this it's worth getting to the bottom of existing annotations too, they may be wrong.
|
Closing this. I decided to not do it in small pieces, because it would be PIA to keep in sync. I'll do bigger chunks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These were easy wins. :)