Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HybridCache: enforce L2 expiration #5987

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

mgravell
Copy link
Member

@mgravell mgravell commented Feb 27, 2025

fix #5824

L1 expiration was being allowed to exceed the original L2 expiration, via either:

  1. intentional (mis)configuration with larger L1 expiration
  2. loading from L2 into L1 inside the local expiration window, which should trim to L2, but was just applying L1 window

Docs explicitly say "not exceeding the remaining overall cache lifetime", so we should not allow this in either case

Microsoft Reviewers: Open in CodeFlow

@mgravell mgravell requested a review from a team as a code owner February 27, 2025 14:58
@mgravell mgravell added bug This issue describes a behavior which is not expected - a bug. area-caching-hybrid labels Feb 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-caching-hybrid bug This issue describes a behavior which is not expected - a bug.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

HybridCache: LocalCacheExpiration is not relative to Expiration
2 participants