Expose default cache key use by DistributedCachingCacheClient #6002
+184
−161
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stephentoub
force-pushed
the
defaultcachekey
branch
from
5d163b4 to
a7df2e9
Compare
We've had requests for this to be available. This just moves the method from the internal CacheHelpers type to DistributedCachingChatClient; the implementation isn't changed at all, other than in arg validation.
stephentoub
force-pushed
the
defaultcachekey
branch
from
a7df2e9 to
0054a9e
Compare
stephentoub
commented
Mar 1, 2025
| } | ||
| else | ||
| { | ||
| serializerOptions.MakeReadOnly(); |
There was a problem hiding this comment.
@eiriktsarpalis, can you remind me why we need to do this?
|
Thanks for exposing this. We have implemented a deduping logger that uses this key generation logic to make it easier to read test output that involves multi-turn conversations. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We've had requests for this to be available separate from DCCC. This just moves the method from the internal CacheHelpers type to DistributedCachingChatClient; the implementation isn't changed at all, other than in arg validation.
Microsoft Reviewers: Open in CodeFlow