removed failsOn attributes

dotnet · Jan 11, 2025 · 75c5d8a · 75c5d8a
1 parent 5b80786
commit 75c5d8a
Show file tree

Hide file tree

Showing 8 changed files with 9 additions and 20 deletions.
diff --git a/...s/tests/TestCases.Android.Tests/snapshots/android/Issue2728TestsItalicLabel.png b/...s/tests/TestCases.Android.Tests/snapshots/android/Issue2728TestsItalicLabel.png
diff --git a/src/Controls/tests/TestCases.Shared.Tests/Tests/Issues/Issue1236.cs b/src/Controls/tests/TestCases.Shared.Tests/Tests/Issues/Issue1236.cs
@@ -15,12 +15,10 @@ public Issue1236(TestDevice testDevice) : base(testDevice)
 		[Test]
 		[Category(UITestCategories.Label)]
 		[Category(UITestCategories.Compatibility)]
-		[FailsOnIOSWhenRunningOnXamarinUITest]
-		[FailsOnMacWhenRunningOnXamarinUITest]
 		public void DelayedLabelBindingShowsUp()
 		{
 			Task.Delay(2000).Wait();
-			App.WaitForNoElement("Lorem Ipsum Dolor Sit Amet");
+			App.WaitForElement("Lorem Ipsum Dolor Sit Amet");
 		}
 	}
 }
diff --git a/src/Controls/tests/TestCases.Shared.Tests/Tests/Issues/Issue14471.cs b/src/Controls/tests/TestCases.Shared.Tests/Tests/Issues/Issue14471.cs
@@ -1,5 +1,4 @@
-#if !MACCATALYST // VerifyScreenshot() is not supported on MacCatalyst
-using NUnit.Framework;
+using NUnit.Framework;
 using UITest.Appium;
 using UITest.Core;
 
@@ -13,7 +12,6 @@ public Issue14471(TestDevice device) : base(device) { }
 
 	[Test]
 	[Category(UITestCategories.Image)]
-	[FailsOnAndroidWhenRunningOnXamarinUITest("Suddenly failing. https://github.com/dotnet/maui/issues/24243")]
 	public void ImageDoesntDisappearWhenNavigatingBack()
 	{
 		App.WaitForElement("image");
@@ -25,5 +23,4 @@ public void ImageDoesntDisappearWhenNavigatingBack()
 		// The test passes if image is loaded
 		VerifyScreenshot();
 	}
-}
-#endif
+}
diff --git a/src/Controls/tests/TestCases.Shared.Tests/Tests/Issues/Issue17789.cs b/src/Controls/tests/TestCases.Shared.Tests/Tests/Issues/Issue17789.cs
@@ -14,7 +14,6 @@ public Issue17789(TestDevice device) : base(device)
 
 		[Test]
 		[Category(UITestCategories.Page)]
-		[FailsOnMacWhenRunningOnXamarinUITest("VerifyScreenshot method not implemented on macOS")]
 		public void ContentPageBackgroundImageSourceWorks()
 		{
 			App.WaitForElement("WaitForStubControl");

diff --git a/src/Controls/tests/TestCases.Shared.Tests/Tests/Issues/Issue2728.cs b/src/Controls/tests/TestCases.Shared.Tests/Tests/Issues/Issue2728.cs
@@ -1,5 +1,4 @@
-#if MACCATALYST
-using NUnit.Framework;
+using NUnit.Framework;
 using UITest.Appium;
 using UITest.Core;
 
@@ -18,12 +17,10 @@ public Issue2728(TestDevice testDevice) : base(testDevice)
 		[Test]
 		[Category(UITestCategories.Label)]
 		[Category(UITestCategories.Compatibility)]
-		[FailsOnMacWhenRunningOnXamarinUITest]
 		public void Issue2728TestsItalicLabel()
 		{
-			App.WaitForNoElement(LabelHome);
-			App.Screenshot("Label rendered with italic font");
+			App.WaitForElement(LabelHome);
+			VerifyScreenshot();
 		}
 	}
-}
-#endif
+}
diff --git a/src/Controls/tests/TestCases.Shared.Tests/Tests/Issues/Issue2983.cs b/src/Controls/tests/TestCases.Shared.Tests/Tests/Issues/Issue2983.cs
@@ -15,8 +15,6 @@ public Issue2983(TestDevice testDevice) : base(testDevice)
 		[Test]
 		[Category(UITestCategories.ListView)]
 		[Category(UITestCategories.Compatibility)]
-		[FailsOnIOSWhenRunningOnXamarinUITest]
-		[FailsOnMacWhenRunningOnXamarinUITest]
 		public void TestDoesNotCrash()
 		{
 			App.WaitForElement("footer");

diff --git a/src/Controls/tests/TestCases.Shared.Tests/Tests/Issues/Issue3089.cs b/src/Controls/tests/TestCases.Shared.Tests/Tests/Issues/Issue3089.cs
@@ -18,11 +18,11 @@ public Issue3089(TestDevice testDevice) : base(testDevice)
 		[Test]
 		[Category(UITestCategories.ListView)]
 		[Category(UITestCategories.Compatibility)]
-		[FailsOnAllPlatformsWhenRunningOnXamarinUITest]
 		public void ResettingItemsOnRecycledListViewKeepsOldText()
 		{
+			App.WaitForElement(Reload);
 			App.Tap(Reload);
-			App.WaitForNoElement(Success);
+			App.WaitForElement(Success);
 		}
 	}
 }
diff --git a/src/Controls/tests/TestCases.iOS.Tests/snapshots/ios/Issue2728TestsItalicLabel.png b/src/Controls/tests/TestCases.iOS.Tests/snapshots/ios/Issue2728TestsItalicLabel.png