Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Gtk] Frame: add mapping for CornerRadius, BorderColor #21351

Closed

Conversation

lytico
Copy link
Contributor

@lytico lytico commented Mar 21, 2024

Description of Change

Frame: add mapping for CornerRadius, BorderColor

refactored from: jsuarezruiz#51

Issues

needs testing in eg. Control.Samples.Gtk

currently showing a frame without content doesn't work in LayoutView

lytico and others added 30 commits September 7, 2022 16:35
# Conflicts:
#	Directory.Build.Override.props.in
#	Directory.Build.props
#	Microsoft.Maui.sln
#	src/Compatibility/Core/src/Compatibility.csproj
#	src/Compatibility/Core/src/Gtk2/Controls/OpenGLView.cs
#	src/Compatibility/Core/src/Gtk2/Renderers/OpenGLViewRenderer.cs
#	src/Controls/Maps/src/Controls.Maps.csproj
#	src/Controls/src/Core/Application/Application.Gtk.cs
#	src/Controls/src/Core/Button/Button.Gtk.cs
#	src/Controls/src/Core/Compatibility/Handlers/VisualElementRenderer.cs
#	src/Controls/src/Core/Controls.Core.csproj
#	src/Controls/src/Core/Editor/Editor.Gtk.cs
#	src/Controls/src/Core/Element/Element.Gtk.cs
#	src/Controls/src/Core/Label/Label.Gtk.cs
#	src/Controls/src/Core/Shape/Shape.Gtk.cs
#	src/Controls/src/Core/TabbedPage/TabbedPage.Gtk.cs
#	src/Controls/src/Core/Window/Window.Gtk.cs
#	src/Core/src/Core.csproj
#	src/Core/src/Platform/ImageSourcePartLoader.cs
#	src/Essentials/src/Essentials.csproj
#	src/Essentials/src/Screenshot/Screenshot.shared.cs
* Update car image/size

* Change name back to dotnet_bot

The old image name was used in a bunch of tests, it's still the bot so the old name is still fine, and seems like reasonable idea to just revert the name to clean this up.

---------

Co-authored-by: redth <[email protected]>
webwarrior-ws and others added 20 commits March 20, 2024 01:47
Update calendar properties SelectedDate, MinimumDate,
MaximumDate when opening calendar popup when it is already
created but hidden.

(cherry picked from commit fe92c90)
DatePicker window location was wrong when we didn't use
x11 GdkBackend. This problem was fixed by setting the
TransientFor property.

Co-authored-by: webwarrior-ws <[email protected]>
(cherry picked from commit 0032339)
Replace deprecated methods.
Used Entry icon instead of defining a new button for datepicker
arrow.

Co-authored-by: webwarrior-ws <[email protected]>
(cherry picked from commit 8c3d7c2)
…: add mapping for CornerRadius, BorderColor (refactored from: jsuarezruiz#51)
@lytico lytico requested review from a team as code owners March 21, 2024 11:26
@dotnet-policy-service dotnet-policy-service bot added the community ✨ Community Contribution label Mar 21, 2024
Copy link
Contributor

Hey there @lytico! Thank you so much for your PR! Someone from the team will get assigned to your PR shortly and we'll get it reviewed.

@lytico
Copy link
Contributor Author

lytico commented Mar 21, 2024

sorry, wrong repo

should be here: jsuarezruiz#66

@lytico lytico closed this Mar 21, 2024
@lytico lytico changed the title Frame: add mapping for CornerRadius, BorderColor [Gtk] Frame: add mapping for CornerRadius, BorderColor Mar 21, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Apr 25, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
community ✨ Community Contribution
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants