Revert "[iOS] Clear BindingContext when cell is queued for reuse (#14… #21400
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
)" This reverts commit 170a7a9. # Conflicts: # src/Controls/src/Core/Handlers/Items/iOS/ItemsViewDelegator.cs # src/Controls/tests/DeviceTests/Elements/CollectionView/CollectionViewTests.cs
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
rmarinho
approved these changes
Mar 22, 2024
jsuarezruiz
approved these changes
Mar 26, 2024
|
@PureWeen Is there a reason this was closed and not merged? |
Agree with this question. We've been hosed on iOS trying to get a release out from this regression and waiting for a fix. The vibe here seemed promising until it was closed unexpectedly. |
|
It's the same timeline for us to fix forward or revert. @SonicScholar if you have an additional repro you could add here #21374 that'd be helpful. At this point it feels riskier to revert vs fix forward given the data we have. This change has been part of the code now for a good amount of time with no other issues logged and @mooola found workaround so it felt more disruptive to revert. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
Revert #14619
It looks like this change caused the following "regression" #21374.
From testing I don't think this change directly caused the regression, but I think it exposed a flaw in the prototype code that now only surfaces because of that PR.
The prototype code inside ItemsViewLayout creates a prototype cell to measure with if no cells have been measured yet. This creates a phantom
TemplatedCellthat gets added to the logical children and causes there to be twoTemplatedCellsfor the sameViewI did a quick test just returning the results of the prototype cell without creating it and it no longer crashes. So, I think we need to rework the prototype cells a bit for SR4