Revert "Fix SafeArea adjustments" #24600
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 14b29b0.
rmarinho
approved these changes
Sep 5, 2024
PureWeen
added a commit
that referenced
this pull request
Sep 5, 2024
samhouts
added
the
fixed-in-net8.0-nightly
samhouts
added
the
fixed-in-net9.0-nightly
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Reverts #23729
This PR regressed Bugzilla28570
I still haven't quite been able to narrow this one down
AFAICT the safearea is being double accounted for
The ScrollView adjusts the contentinset when it does a measure
but then when it does the actual measure
The height on that measure gets turned into "Infinity" by the scrollview measure code here
because of that the measure here doesn't get clamped
This is kind of an odd case because the ScrollView in Bugzilla28570 is unbounded since it's inside a StackLayout.
The adjustment for the safearea on a stacklayout is kind of silly because if the height of the SL is 4000 from the content the adjustment from the bottom safe area is pointless.
Stacklayouts should probably never adjust from bottom or right safe area padding.
for example here you can see it adjust down 3659 by 34 from the bottom