-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[net9.0] Merge main to net9.0 #24953
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Fixed-19859 : NavigationPage: Title not updating * test cases added. * testcases updated. * updated Issue19859.xaml * Added snapshots.
…24806) * fix added * UI test added * platform affected codes updated * script file changes updated * review changes updated * Test case file changes updated * tabbar automation id casing updated * Automation ID changed for button * unshipped file changes reverted * changes updated * platform condition updated * UI test modified * screen shot added * access specifier changed
We will be migrating to the newer https://github.com/apps/similar-issues-ai app
* [X] Ignore Parent DataType on collection Picker.ItemDisplayBinding for example shouldn't inherit parent DataType - fixes #23989 * fixtrimming * suppresswarning * Update src/TestUtils/src/Microsoft.Maui.IntegrationTests/Utilities/BuildWarningsUtilities.cs
* fix added * UI test added * test case platform affected changes added * test case changes added * UI test changes added * script file method name updated * ui test changes added * script file platform condition added * output snapshots images added * ui test file changes added * Fix Shell title update issue * images added for all platform * changes reverted * fix added * UI test added * test case platform affected changes added * test case changes added * UI test changes added * script file method name updated * ui test changes added * script file platform condition added * output snapshots images added * ui test file changes added * Fix Shell title update issue * images added for all platform * changes reverted * image added * image added
…es when adding a new item to a group or when adding a new group. (#24873) * [iOS] CollectionView issue fix. * Added test case. * Added snapshots.
Redth
previously approved these changes
Sep 27, 2024
# Conflicts: # src/Controls/src/Core/Element/Element.cs # src/Controls/src/Core/PublicAPI/net-windows/PublicAPI.Unshipped.txt # src/Controls/src/Xaml/XamlServiceProvider.cs # src/Controls/tests/Xaml.UnitTests/Controls.Xaml.UnitTests.csproj # src/TestUtils/src/Microsoft.Maui.IntegrationTests/Utilities/BuildWarningsUtilities.cs
rmarinho
force-pushed
the
merge-main-net9
branch
from
September 27, 2024 00:16
54887d5
to
2fcf50b
Compare
Redth
previously approved these changes
Sep 27, 2024
rmarinho
commented
Sep 27, 2024
@@ -782,7 +782,7 @@ internal void OnResourcesChanged(IEnumerable<KeyValuePair<string, object>> value | |||
internal override void OnSetDynamicResource(BindableProperty property, string key, SetterSpecificity specificity) | |||
{ | |||
base.OnSetDynamicResource(property, key, specificity); | |||
if (!DynamicResources.TryGetValue(property, out var existing) || existing.Item2 < specificity) | |||
if (!DynamicResources.TryGetValue(property, out var existing) || existing.Item2 <= specificity) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@StephaneDelcroix is this ok?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes
rmarinho
force-pushed
the
merge-main-net9
branch
from
September 30, 2024 12:24
090c39d
to
ec09d9e
Compare
* WIPWIP * Feedback * Refactor usage of `FocusManager` to avoid weak table usage * Use ConditionalWeakTable --------- Co-authored-by: Alberto Aldegheri <[email protected]>
Update default host address to 0.0.0.1.
rmarinho
force-pushed
the
merge-main-net9
branch
from
September 30, 2024 12:30
ec09d9e
to
fa850a7
Compare
samhouts
added
the
fixed-in-net9.0-nightly
This may be available in a nightly release!
label
Oct 1, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
Bring last changes from main to net9.0