Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Android] RefreshView in a grid #25413

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from 2 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 27 additions & 0 deletions src/Controls/tests/TestCases.HostApp/Issues/Issue25368.xaml
Original file line number Diff line number Diff line change
@@ -0,0 +1,27 @@
<?xml version="1.0" encoding="utf-8" ?>
<ContentPage xmlns="http://schemas.microsoft.com/dotnet/2021/maui"
xmlns:x="http://schemas.microsoft.com/winfx/2009/xaml"
x:Class="Maui.Controls.Sample.Issues.Issue25368">
<Grid RowDefinitions="*,Auto"
ColumnDefinitions="Auto,*">
<RefreshView Grid.Row="0"
Grid.ColumnSpan="2">
<CollectionView AutomationId="CollectionView"
x:Name="cv">
<CollectionView.ItemTemplate>
<DataTemplate>
<Label Text="{Binding .}"
AutomationId="{Binding .}"
TextColor="Black"/>
</DataTemplate>
</CollectionView.ItemTemplate>
</CollectionView>
</RefreshView>
<ContentView
Grid.Row="1"
Grid.ColumnSpan="2"
BackgroundColor="Black"
HeightRequest="200">
</ContentView>
</Grid>
</ContentPage>
12 changes: 12 additions & 0 deletions src/Controls/tests/TestCases.HostApp/Issues/Issue25368.xaml.cs
Original file line number Diff line number Diff line change
@@ -0,0 +1,12 @@
namespace Maui.Controls.Sample.Issues
{
[Issue(IssueTracker.Github, 25368, "Android RefreshView in a grid can break the grid layout", PlatformAffected.Android)]
public partial class Issue25368 : ContentPage
{
public Issue25368()
{
InitializeComponent();
cv.ItemsSource = Enumerable.Range(1, 100);
}
}
}
Original file line number Diff line number Diff line change
@@ -0,0 +1,26 @@
using NUnit.Framework;
using UITest.Appium;
using UITest.Core;

namespace Microsoft.Maui.TestCases.Tests.Issues
{
public class Issue25368 : _IssuesUITest
{
public Issue25368(TestDevice testDevice) : base(testDevice)
{
}

public override string Issue => "Android RefreshView in a grid can break the grid layout";

[Test]
[Category(UITestCategories.RefreshView)]
public void Issue2775Test()
{
App.WaitForElement("1");
App.ScrollDown("CollectionView", ScrollStrategy.Gesture, swipePercentage: 0.9);
App.ScrollDown("CollectionView", ScrollStrategy.Gesture, swipePercentage: 0.9);
App.ScrollDown("CollectionView", ScrollStrategy.Gesture, swipePercentage: 0.9);
App.WaitForElement("100");
}
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,8 @@ protected override MauiSwipeRefreshLayout CreatePlatformView()
return new MauiSwipeRefreshLayout(Context);
}

public override bool NeedsContainer => true;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you include a comment in code here explaining why is necessary? Would be useful for other contributors and reviewing the code in the future.


protected override void ConnectHandler(MauiSwipeRefreshLayout platformView)
{
base.ConnectHandler(platformView);
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -52,6 +52,7 @@ Microsoft.Maui.WebProcessTerminatedEventArgs.Sender.get -> Android.Views.View?
override Microsoft.Maui.Handlers.HybridWebViewHandler.ConnectHandler(Android.Webkit.WebView! platformView) -> void
override Microsoft.Maui.Handlers.HybridWebViewHandler.CreatePlatformView() -> Android.Webkit.WebView!
override Microsoft.Maui.Handlers.HybridWebViewHandler.DisconnectHandler(Android.Webkit.WebView! platformView) -> void
override Microsoft.Maui.Handlers.RefreshViewHandler.NeedsContainer.get -> bool
override Microsoft.Maui.Platform.MauiHybridWebViewClient.Dispose(bool disposing) -> void
override Microsoft.Maui.Platform.MauiHybridWebViewClient.ShouldInterceptRequest(Android.Webkit.WebView? view, Android.Webkit.IWebResourceRequest? request) -> Android.Webkit.WebResourceResponse?
override Microsoft.Maui.Platform.MauiWebViewClient.OnRenderProcessGone(Android.Webkit.WebView? view, Android.Webkit.RenderProcessGoneDetail? detail) -> bool
Expand Down
Loading