Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Windows] Fix for the screen does not display when changing the CurrentPage of a TabbedPage #25690

Closed
wants to merge 4 commits into from
Closed

[Windows] Fix for the screen does not display when changing the CurrentPage of a TabbedPage #25690

wants to merge 4 commits into from

Conversation

Tamilarasan-Paranthaman
Copy link
Contributor

Root cause

While navigating to the next page, the MeasureOverride method is repeatedly called on the parent, which prevents the Arrange method from being called.

Description of change

The OnChildMeasureInvalidatedInternal method has been modified to ensure that measure invalidation is only propagated to the parent when necessary, preventing unnecessary repeated calls to OnChildMeasureInvalidatedInternal.

References

Issues Fixed

Fixes #25518

Tested the behaviour in the following platforms

  • Android
  • Windows
  • iOS
  • Mac

Screenshot

FixVideo.mp4

@dotnet-policy-service dotnet-policy-service bot added the community ✨ Community Contribution label Nov 5, 2024
@jsuarezruiz
Copy link
Contributor

Could you rebase to fix the conflicts? Thanks in advance.

@albyrock87
Copy link
Contributor

@Tamilarasan-Paranthaman may you check if #25664 solves this issue too?

@PureWeen PureWeen self-assigned this Nov 6, 2024
PureWeen
PureWeen requested changes Nov 6, 2024
View reviewed changes
Copy link
Member

@PureWeen PureWeen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add a test

@Shalini-Ashokan
Copy link
Contributor

/rebase

@Shalini-Ashokan
Copy link
Contributor

@PureWeen, I have added test cases

@Tamilarasan-Paranthaman Tamilarasan-Paranthaman marked this pull request as ready for review November 7, 2024 09:40
@Tamilarasan-Paranthaman Tamilarasan-Paranthaman requested a review from a team as a code owner November 7, 2024 09:40
@PureWeen
Copy link
Member

PureWeen commented Nov 9, 2024

Closing this for now

#25518 (comment)

@PureWeen PureWeen closed this Nov 9, 2024
@sheiksyedm sheiksyedm added the partner/syncfusion Issues / PR's with Syncfusion collaboration label Dec 6, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Jan 5, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@PureWeen PureWeen PureWeen requested changes

@rmarinho rmarinho Awaiting requested review from rmarinho rmarinho is a code owner automatically assigned from dotnet/dotnet-maui-reviewers

@jsuarezruiz jsuarezruiz Awaiting requested review from jsuarezruiz jsuarezruiz is a code owner automatically assigned from dotnet/dotnet-maui-reviewers

Assignees

@PureWeen PureWeen

Labels
area-controls-tabbedpage TabbedPage community ✨ Community Contribution partner/syncfusion Issues / PR's with Syncfusion collaboration platform/windows 🪟
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Windows] The screen does not display when changing the CurrentPage of a TabbedPage.
6 participants
@Tamilarasan-Paranthaman @jsuarezruiz @albyrock87 @Shalini-Ashokan @PureWeen @sheiksyedm