Fix the ListView scroll position center and end without animation #27001
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey there @Shalini-Ashokan! Thank you so much for your PR! Someone from the team will get assigned to your PR shortly and we'll get it reviewed. |
|
@dotnet-policy-service agree company="Syncfusion, Inc." |
karthikraja-arumugam
added
the
partner/syncfusion
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
There was a problem hiding this comment.
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
Comments suppressed due to low confidence (2)
src/Controls/tests/TestCases.Shared.Tests/Tests/Issues/Issue26945.cs:18
- The test method name
Issue26945_SelectItemPositionStartis inconsistent with the other test method names. It should be renamed toIssue26945Test_SelectItemPositionStart.
public void Issue26945_SelectItemPositionStart()
src/Controls/tests/TestCases.HostApp/Issues/Issue26945.cs:6
- The class name 'Issue26857' appears to be a typo. It should be renamed to 'Issue26945' to match the issue being addressed.
public class Issue26857 : ContentPage
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
jsuarezruiz
reviewed
Jan 10, 2025
| switch (toPosition) | ||
| { | ||
| case ScrollToPosition.Start: | ||
| ListView.ScrollTo(ListView.SelectedItem, ScrollToPosition.Start, false); |
There was a problem hiding this comment.
Could modify the sample using for example, a CheckBox, to use the ScrollTo method with the animated parameter using true and also false values?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue Details
The ListView.ScrollTo method fails to correctly scroll the selected item to the center or end of the ListView on the Windows platform. Instead, the scroll position always remains at the start and does not align the SelectedItem with the center or end of the list, especially when using it without animation.
Root Cause
The scroll position is reset before scrolling the ListView item (center or end) when using it without animation.
Description of Change
Scroll the ListView item (center or end) before resetting the scroll position value.
Validated the behavior in the following platforms
Issues Fixed
Fixes #26945
Output ScreenShot
BeforeFixWithoutAnimation.mp4
AfterFixWithoutAnimation.mp4