[vs17.13] Adjust embeddedresource culture warning #11320
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #11313
Summary
The newly added
MSB3002has a breaking potential (while it's very correct). So making it an opt-in behavior("MSB3002: Explicitly set culture "{0}" for item "{1}" was overwritten with inferred culture "{2}", because 'RespectAlreadyAssignedItemCulture' property was not set.")
Customer Impact
If user took behavior on old incorrect behavior (explicitly set
Culturemetadata on EmbeddedResource were overwritten with culture inferred from the file extension) or they just don't care - they might be broken by the new warning that they might not appreciate.Regression?
Yes.
The warning was newly added (in 17.13)
Testing
Targetted test is testing the scenarios with explicit and implicit culture.
Risk
Minimal (making the new warning opt-in).