Clustering: ensure snapshots are globally uniform #9115
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While validating #9103, I uncovered this bug in membership which allows inconsistent membership views between replicas.
Currently, membership always reflected the silo's local view of its own status (eg
ShuttingDownvsActive) and incorporates that into any membership snapshot it receives. For algorithms relying on consistent membership snapshots, this cannot be allowed. This PR changes the behavior so that each silo sees what every other silo sees for a given membership version.Microsoft Reviewers: Open in CodeFlow