CA1044 Implementation and Unit Test #827
Conversation
|
Hi @Anniepoh, I'm your friendly neighborhood .NET Foundation Pull Request Bot (You can call me DNFBOT). Thanks for your contribution! TTYL, DNFBOT; |
|
Hi @Anniepoh, I'm your friendly neighborhood .NET Foundation Pull Request Bot (You can call me DNFBOT). Thanks for your contribution! TTYL, DNFBOT; |
|
Oops...accidental close it. |
|
@Anniepoh, Thanks for signing the contribution license agreement so quickly! Actual humans will now validate the agreement and then evaluate the PR. |
|
@Anniepoh, Thanks for signing the contribution license agreement so quickly! Actual humans will now validate the agreement and then evaluate the PR. |
|
@Anniepoh, Thanks for signing the contribution license agreement so quickly! Actual humans will now validate the agreement and then evaluate the PR. |
| @@ -6,20 +6,19 @@ | |||
| using Analyzer.Utilities; | |||
|
|
|||
| namespace Microsoft.ApiDesignGuidelines.Analyzers | |||
| { | |||
| { | |||
| /// <summary> | |||
| /// CA1044: Properties should not be write only | |||
| /// </summary> | |||
| public abstract class PropertiesShouldNotBeWriteOnlyAnalyzer : DiagnosticAnalyzer | |||
There was a problem hiding this comment.
You can make this class sealed and delete the CSharp and VB derived classes since this analyzer is language-agnostic.
There was a problem hiding this comment.
Hi Sri,
For this one I tried to add sealed last night but then ran into syntax problems in the UnitTest code which I didn't quite understand. Let me look around and get back.
There was a problem hiding this comment.
Done. Code is coming...
|
@Anniepoh, Thanks for signing the contribution license agreement so quickly! Actual humans will now validate the agreement and then evaluate the PR. |
|
Closing this in favor of #882 |
Implemented code and unit tests for CA1044 based on FXCop code.
Code has tests commented out that had issues. I am not quite certain why. If someone can shed some light, that would be great.
Mentor = Felix Cho.
Code Partner = maggiemsft
Lead = Sri.
cc @maggiemsft
cc @srivatsn
Fixes #390