Switch to using field+auto-prop #76906
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotnet-issue-labeler
bot
added
Area-IDE
untriaged
CyrusNajmabadi
force-pushed
the
actuallyUseAutoProps
branch
from
1b831d0 to
e2b5e9e
Compare
CyrusNajmabadi
force-pushed
the
actuallyUseAutoProps
branch
from
e2b5e9e to
733debf
Compare
tmat
reviewed
Jan 24, 2025
| @@ -53,10 +50,11 @@ public static SolutionId CreateFromSerialized(Guid id, string debugName = null) | |||
| return new SolutionId(id, debugName); | |||
| } | |||
|
|
|||
| internal string DebugName => _debugName; | |||
| [field: DataMember(Order = 1)] | |||
| internal string DebugName { get; } | |||
There was a problem hiding this comment.
Move the property in front of the constructor.
|
I think the refactoring should move the property declaration to where the field declaration used to be if it's removing it. Or maybe we need to run follow up refactoring that groups data-backed members together. Having (semi)auto-properties scattered across the type declaration makes it difficult to see what data the object holds onto, weather it has any mutable state, what the value of |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.