[webcil] Minor cleanups #81009
Merged
[webcil] Minor cleanups #81009
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Let the C compiler do the math
|
Tagging subscribers to 'arch-wasm': @lewing Issue DetailsContributes to #808087
|
lambdageek
force-pushed
the
fix-webcil-nits
branch
from
87d4bcc to
88791f6
Compare
lambdageek
force-pushed
the
fix-webcil-nits
branch
from
88791f6 to
d86aec9
Compare
lambdageek
requested review from
radical,
lewing,
pavelsavara,
vargaz,
SamMonoRT and
thaystg
as code owners
vargaz
approved these changes
Jan 23, 2023
pavelsavara
reviewed
Jan 23, 2023
radical
reviewed
Jan 23, 2023
radical
reviewed
Jan 23, 2023
But log whether we actually copied anything or not Co-authored-by: Ankit Jain <[email protected]>
|
/azp run runtime-wasm |
|
Azure Pipelines successfully started running 1 pipeline(s). |
mdh1418
pushed a commit
to mdh1418/runtime
that referenced
this pull request
Jan 24, 2023
* replace magic constants by strlen(LITERAL) Let the C compiler do the math * Use CopyIfDifferent for webcil converter in WasmAppBuilder * WasmAppHost: serve .webcil as application/octet-stream * Add mime types for webcil in two more places * Always add to _fileWrites But log whether we actually copied anything or not Co-authored-by: Ankit Jain <[email protected]>
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contributes to #80807
strlen(LITERAL)instead of magic constants in C. the compiler will turn them into constants anywayCopyIfDifferentin WasmAppBuilder when converting webcil.