BrowserDebugProxy: unify debug metadata reading for PE and Webcil #81099
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tagging subscribers to this area: @thaystg Issue DetailsFactor common code out into a Note: WebcilReader doesn't implement Contributes to #80807
|
|
Tagging subscribers to 'arch-wasm': @lewing Issue DetailsFactor common code out into a TODO
Contributes to #80807
|
|
Keeping it a draft until I add the pdb checksum reader for webcil |
lambdageek
force-pushed
the
feature-webcil-debug-refactor
branch
from
81f43ac to
5b5e844
Compare
16 tasks
thaystg
approved these changes
Jan 24, 2023
radical
approved these changes
Jan 24, 2023
src/libraries/Microsoft.NET.WebAssembly.Webcil/src/Webcil/WebcilReader.cs
Outdated
Show resolved
Hide resolved
src/libraries/Microsoft.NET.WebAssembly.Webcil/src/Webcil/WebcilReader.cs
Outdated
Show resolved
Hide resolved
src/libraries/Microsoft.NET.WebAssembly.Webcil/src/Webcil/WebcilReader.cs
Outdated
Show resolved
Hide resolved
Co-authored-by: Ankit Jain <[email protected]>
Also switch from cascade of 'if's to a 'switch' when looking at debug entries
lambdageek
force-pushed
the
feature-webcil-debug-refactor
branch
from
9ebd6d8 to
0e4cdf6
Compare
lambdageek
force-pushed
the
feature-webcil-debug-refactor
branch
from
0e4cdf6 to
45b7c47
Compare
|
/azp run runtime-wasm |
|
Azure Pipelines successfully started running 1 pipeline(s). |
radical
approved these changes
Jan 24, 2023
src/libraries/Microsoft.NET.WebAssembly.Webcil/src/Webcil/WebcilReader.Reflection.cs
Outdated
Show resolved
Hide resolved
src/libraries/Microsoft.NET.WebAssembly.Webcil/src/Webcil/WebcilReader.Reflection.cs
Outdated
Show resolved
Hide resolved
src/libraries/Microsoft.NET.WebAssembly.Webcil/src/Webcil/WebcilReader.Reflection.cs
Outdated
Show resolved
Hide resolved
This was referenced Jan 25, 2023
Co-Authored-By: Ankit Jain <[email protected]>
|
/azp run runtime-wasm |
|
Azure Pipelines successfully started running 1 pipeline(s). |
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Factor common code out into a
MetadataDebugSummaryusing an adapter to read from eitherPEReaderorWebcilReader.WebcilReader.ReadPdbChecksumDebugDirectoryDataContributes to #80807