Aspire notifications #44348
Draft
Aspire notifications #44348
+626
−273
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotnet-issue-labeler
bot
added
Area-ApiCompat
untriaged
tmat
force-pushed
the
AspireNotifications
branch
from
5e1ce4b
to
ef3df33
Compare
tmat
force-pushed
the
AspireNotifications
branch
2 times, most recently
from
623141b
to
3ac422b
Compare
tmat
force-pushed
the
AspireNotifications
branch
from
178ec3d
to
eabb5d4
Compare
davidfowl
reviewed
Oct 25, 2024
Comment on lines
+388
to
+389
| using var cancelTokenSource = CancellationTokenSource.CreateLinkedTokenSource( | ||
| cancellationToken, _shutdownCancellationTokenSource.Token, connection.HttpRequestAborted); |
There was a problem hiding this comment.
This seems like a bit much per message.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement Aspire DCP notification.
Improve shutdown, process disposal and restarting logic to support Aspire scenarios.