-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Aspire notifications #44348
Draft
tmat
wants to merge
7
commits into
dotnet:release/9.0.2xx
Choose a base branch
from
tmat:AspireNotifications
base: release/9.0.2xx
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Aspire notifications #44348
+626
−273
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotnet-issue-labeler
bot
added
Area-ApiCompat
untriaged
Request triage from a team member
labels
Oct 22, 2024
tmat
force-pushed
the
AspireNotifications
branch
from
October 22, 2024 16:15
5e1ce4b
to
ef3df33
Compare
tmat
force-pushed
the
AspireNotifications
branch
2 times, most recently
from
October 25, 2024 03:35
623141b
to
3ac422b
Compare
tmat
force-pushed
the
AspireNotifications
branch
from
October 25, 2024 04:04
178ec3d
to
eabb5d4
Compare
davidfowl
reviewed
Oct 25, 2024
Comment on lines
+388
to
+389
using var cancelTokenSource = CancellationTokenSource.CreateLinkedTokenSource( | ||
cancellationToken, _shutdownCancellationTokenSource.Token, connection.HttpRequestAborted); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This seems like a bit much per message.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggestions?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement Aspire DCP notification.
Improve shutdown, process disposal and restarting logic to support Aspire scenarios.