Fix and simplify logic for setting the minimum VS version to display in the installer UI #44412
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotnet-issue-labeler
bot
added
Area-Install
untriaged
marcpopMSFT
added
Servicing-consider
and removed
untriaged
marcpopMSFT
changed the title
wtgodbe
approved these changes
Oct 23, 2024
|
Approved on Teams |
|
Confirmed working |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #44360
Summary
When SDK and installer were separate repos, we had logic in installer to update the displayed minimum VS version required in the installer Ux. the problem is that we support running on N-1 but require N VS version to actually target the current version (ie we will load in 17.11 but require 17.12 to target net9.0). So logic was added to read that value and increment it but that logic didn't handle a two digit minor VS version.
We noticed previously that this logic of calculating the value on the fly could end up producing a long addition math error (ie we'd get 17.900000000001) as the value when adding .1, let's just hard code this value.
Customer Impact
Currently it says you have to install 17.21 to target net9.
Regression
Yes
Testing
Build the installer locally
Risk
In the future when updating the minimum version, we now have to update it in multiple places but they are all in one repo.