[ApiCompat] Warn if abstract keyword is removed from member #46797
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…verifies if the abstract keyword was removed.
ericstj
reviewed
Feb 13, 2025
src/Compatibility/ApiCompat/Microsoft.DotNet.ApiCompatibility/Resources.resx
Show resolved
Hide resolved
ericstj
approved these changes
Feb 13, 2025
| CreateType(" abstract class", " public abstract void F();"), | ||
| CreateType(" abstract class", " public virtual void F() {}"), | ||
| false, | ||
| new CompatDifference[] { } |
There was a problem hiding this comment.
Nit:
Suggested change
| new CompatDifference[] { } | |
| CreateDifferences() |
|
Does this also account for strict mode in which the API members should be equal? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #46794
Removing the
abstractkeyword from a member should be disallowed by ApiCompat, but it currently does not know how to handle that case like it used to in the old version.The lack of warning in ApiCompat caused the introduction of this bug in maintenance-packages
System.Reflection.DispatchProxy: dotnet/maintenance-packages#194 which we fixed with dotnet/maintenance-packages#202