Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove native AOT error when skipping native compilation #46839

Merged
merged 1 commit into from
Feb 14, 2025

Conversation

sbomer
Copy link
Member

@sbomer sbomer commented Feb 13, 2025

I believe this will fix #46790, but see the discussion in that issue. Not sure yet if this is the best approach.

@Copilot Copilot bot review requested due to automatic review settings February 13, 2025 21:31
@sbomer sbomer requested review from AntonLapounov and a team as code owners February 13, 2025 21:31

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot wasn't able to review any files in this pull request.

Files not reviewed (1)
  • src/Tasks/Microsoft.NET.Build.Tasks/targets/Microsoft.NET.Publish.targets: Language not supported
@dotnet-issue-labeler dotnet-issue-labeler bot added Area-Infrastructure untriaged Request triage from a team member labels Feb 13, 2025
Copy link
Member

@ivanpovazan ivanpovazan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verified that dotnet build of an iOS app, does not throw the error when configured with:

<Project Sdk="Microsoft.NET.Sdk">
  <PropertyGroup>
    <OutputType>Exe</OutputType>
    <TargetFramework>net10.0-ios</TargetFramework>
    <PublishAot>true</PublishAot>
  </PropertyGroup>
</Project>

@sbomer sbomer merged commit 2f1799b into dotnet:main Feb 14, 2025
42 checks passed
@sbomer
Copy link
Member Author

sbomer commented Feb 14, 2025

/backport to release/10.0.1xx-preview1

Copy link
Contributor

Started backporting to release/10.0.1xx-preview1: https://github.com/dotnet/sdk/actions/runs/13334976249

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-Infrastructure untriaged Request triage from a team member
Projects
None yet
Development

Successfully merging this pull request may close these issues.

NativeAOT broken for Apple TFMs in .NET 10
4 participants