[Accessibility] NVDA tool does not show focus blue rectangle in property edit

[MelonWang1]

.NET version

.NET 10.0.100-alpha.1.24573.1

Did it work in .NET Framework?

Yes

Did it work in any of the earlier releases of .NET Core or .NET 5+?

Yes, also can repro in .NET8.0/9.0, cannot repro in .NET 6.0/7.0.

Issue description

Current Behavior

NVDA does not show focus blue rectangle.

10.0mp4.mp4

Expected Behavior

NVDA should show focus blue rectangle.
In .NET7.0/6.0:

6.0mp4.mp4

In .NET Framework:

Steps to reproduce

1. Create a .NET Core Winforms project.
2. Add a Button and PropertyGrid controls in form designer.
3. Set the SelectedObject property to Button1 in propertyGrid1 control.
4. Build and run project.
5. Open NVDA tool and select FlatStyle property in propertyGrid control.
6. Press Tab (should focus on edit part)

[LeafShi1]

@MelonWang1 Could you please test if the issue is related to the version of NAVD and confirm if the issue occurs in Narrator or JAWS?

[MelonWang1]

@LeafShi1 This issue cannot repro in Narrator tool, can repro in latest NVDA tool version 2024.4.1.
Narrator:

NVDA:

[LeafShi1]

This issue caused by the changes in PR #9321

[ricardobossan]

This issue caused by the changes in PR #9321

@Tanya-Solyanik I tried reverting the PR, and it did resolve the issue, so @LeafShi1 is spot on!

However, the conversion from User32 to CsWin32 was a massive shift. Most of the specific changes across the 190 files can’t be individually reverted to isolate the trigger for the issue, as they rely on the old User32 methods and properties that no longer exist. It’s like flipping a switch: either everything works or nothing does.

Given that, it’s really difficult to pinpoint what specifically affected the NVDA functionality in this PR. I’m at a bit of a loss on how to approach this. Any suggestions or thoughts on next steps?

[LeafShi1]

This issue seems to be because the MSAA event is not triggered, resulting in the GridViewTextBox's state cannot be read by NVDA.

I tried to add the event AccessibilityNotifyClients(AccessibleEvents.Focus, 0, -1); in method GridViewTextBox.OnGotFocus(), but the following exception is thrown during the code running

@ricardobossan Please verify whether we can add MSAA events to GridViewTextBox before #9321

[ricardobossan]

@LeafShi1 I checked out the commit right before PR #9321 and added the following line to the GridViewTextBox.OnGotFocus() method:

AccessibilityNotifyClients(AccessibleEvents.Focus, 0, -1);

After adding this, I tested the reproduction steps while debugging. However, no error was thrown, and the issue did not reproduce for me.

[chaowendy]

Verified this issue in the latest .NET 10.0 SDK build: 10.0.100-alpha.1.24623.6 + private dlls built from the main branch of Winforms repo, now NVDA show focus blue rectangle in property edit.

But there is a regression issue that each option will be read three times, and from alphanumeric long to short the last time will be announced extra word "instead", for example from 'Flat' to 'System', will be read once "System selected instead".

which is only read once before.

[LeafShi1]

The last time announced extra word "instead" is caused by the code

winforms/src/System.Windows.Forms/src/System/Windows/Forms/Controls/TextBox/TextBoxBase.cs

Line 1732 in 49c20e5

PInvokeCore.SendMessage(this, PInvokeCore.EM_SETSEL, (WPARAM)start, (LPARAM)end);

[LeafShi1]

@JeremyKuhne Can you take a look at this issue, it is a regression caused by PR #9321

After I added MSAA events(PR #12651) to the control, the NVDA rectangle can focus on the property edit box, but before PR #9321, we don't need to add this extra MSAA event. And adding this event will cause NVDA to read the edit box information three times.

[LeafShi1]

The root cause in Control.ControlAccessibleObject.cs