Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add MSAA event to method OnGotFocus of the Control.cs #12651

Merged

Conversation

LeafShi1
Copy link
Member

@LeafShi1 LeafShi1 commented Dec 17, 2024

Fixes #12565

Proposed changes

  • Add MSAA event to method OnGotFocus of the Control.cs

Customer Impact

  • NVDA tool can show focus blue rectangle in property edit textbox

Regression?

  • Yes

Risk

  • Minimal

Screenshots

Before

NVDA does not show focus blue rectangle.

10.0mp4.mp4

After

NVDA should show focus blue rectangle.
AfterChange

Test methodology

  • Manually

Test environment(s)

  • .net 10.0.0-beta.24613.2
Microsoft Reviewers: Open in CodeFlow

@LeafShi1 LeafShi1 requested a review from a team as a code owner December 17, 2024 10:24
Copy link

codecov bot commented Dec 17, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 76.03365%. Comparing base (a5281d9) to head (b91fd1e).
Report is 13 commits behind head on main.

Additional details and impacted files
@@                 Coverage Diff                  @@
##                main      #12651          +/-   ##
====================================================
- Coverage   97.03492%   76.03365%   -21.00128%     
====================================================
  Files           1182        3178        +1996     
  Lines         354561      639601      +285040     
  Branches        5411       47215       +41804     
====================================================
+ Hits          344048      486312      +142264     
- Misses          9724      149772      +140048     
- Partials         789        3517        +2728     
Flag Coverage Δ
Debug 76.03365% <0.00000%> (-21.00128%) ⬇️
integration 18.17775% <0.00000%> (?)
production 49.82847% <0.00000%> (?)
test 97.02820% <ø> (-0.00673%) ⬇️
unit 47.04846% <0.00000%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

@ricardobossan
Copy link
Member

I proceeded to test the PR and the issue seems resolved:

12651

All LGTM!

Copy link
Member

@Tanya-Solyanik Tanya-Solyanik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@Tanya-Solyanik Tanya-Solyanik added the ready-to-merge PRs that are ready to merge but worth notifying the internal team. label Dec 18, 2024
@LeafShi1 LeafShi1 merged commit 58d5c74 into dotnet:main Dec 19, 2024
8 checks passed
@dotnet-policy-service dotnet-policy-service bot added this to the 10.0 Preview1 milestone Dec 19, 2024
@dotnet-policy-service dotnet-policy-service bot removed the ready-to-merge PRs that are ready to merge but worth notifying the internal team. label Dec 19, 2024
Tanya-Solyanik pushed a commit to Tanya-Solyanik/winforms that referenced this pull request Dec 19, 2024
@LeafShi1 LeafShi1 deleted the Fix_12565_AddMSAAEvent_To_Control_OnGotFocus branch January 13, 2025 01:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Accessibility] NVDA tool does not show focus blue rectangle in property edit
3 participants