Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

React to NuGet package pruning warnings #12955

Merged
merged 1 commit into from
Feb 14, 2025
Merged

Conversation

ViktorHofer
Copy link
Member

@ViktorHofer ViktorHofer commented Feb 14, 2025

Contributes to dotnet/sdk#46829

NuGet added a new feature that automatically prunes package and project references that are provided by the shared framework that is targeted.

Resolve the warnings that got emitted when building the repository in non-source-only mode.

Microsoft Reviewers: Open in CodeFlow

Contributes to dotnet/sdk#46829

NuGet added a new feature that automatically prunes package and project references that are provided by the shared framework that is targeted.

Resolve the one warning that got emitted when building the repository in non-source-only mode.
@ViktorHofer ViktorHofer requested a review from a team as a code owner February 14, 2025 11:56
@ViktorHofer ViktorHofer enabled auto-merge (squash) February 14, 2025 12:18
Copy link

codecov bot commented Feb 14, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.95378%. Comparing base (12d120b) to head (53e3e50).
Report is 3 commits behind head on main.

Additional details and impacted files
@@                 Coverage Diff                  @@
##                main      #12955          +/-   ##
====================================================
+ Coverage   75.97906%   96.95378%   +20.97471%     
====================================================
  Files           3265        1218        -2047     
  Lines         643272      356671      -286601     
  Branches       47426        5524       -41902     
====================================================
- Hits          488752      345806      -142946     
+ Misses        150962       10026      -140936     
+ Partials        3558         839        -2719     
Flag Coverage Δ
Debug 96.95378% <ø> (+20.97471%) ⬆️
integration ?
production ?
test 96.95378% <ø> (-0.00057%) ⬇️
unit ?

Flags with carried forward coverage won't be shown. Click here to find out more.

@ViktorHofer ViktorHofer merged commit 9249b89 into main Feb 14, 2025
8 checks passed
@ViktorHofer ViktorHofer deleted the NuGetPackagePruningReaction2 branch February 14, 2025 18:01
@dotnet-policy-service dotnet-policy-service bot added this to the 10.0 Preview2 milestone Feb 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants