feat: crossfade #92
Open
feat: crossfade #92
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…into dev-crossfade
…into dev-crossfade
… dev-crossfade
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this PR is WIP; code quality is quite bad but I need advice on how to properly implement this. Functionality-wise it seems to work.
while exoplayer does not natively support crossfade/gapless playback, crossfade can be achieved by rotating 2 exoplayers on track switching. I initialized 2 exoplayers in BaseAudioPlayer and made fun switchExoplayer that rotates exoplayer to NotificationManager, and added volume fade. The 2 exoplayers have synchronous queues and queue positions, so seekToNextMediaItem/Previous will work as intended.
MainAcitivity has a refresh button that plays the next track with crossfade for the demo.