Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature/Courseflow-api #448

Open
wants to merge 43 commits into
base: new/course-flow
Choose a base branch
from

Conversation

DudeUnleashed
Copy link

@DudeUnleashed DudeUnleashed commented Oct 15, 2024

Description

This PR includes all the Courseflow API developed over t1 and t2 2024 as the feature branch. This implements the following API entities:
Course, Course Map, Course Map Unit, Unit Definition, Specialization, Requirement Set

Type of change

  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

To test each endpoint you can use the following command, just modified for the specific filename, the below is the example
bundle exec rails test test/api/courseflow/course_api_test.rb

There are various rake commands added for generating testing data, they're under the courseflow_testing.rake file, key commands include
rake db:check_courseflow_data
rake db:populate_fixed_courseflow_data

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation if appropriate
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • I have created or extended unit tests to address my new additions
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

If you have any questions, please contact @macite or @jakerenzella.

macite and others added 30 commits June 11, 2024 20:13
Also correct the pdf reading test
Removed the git diff comments left over from rebasing to 9.x from development
removed the git diff comments left over from rebasing to 9.x from development
removed the git diff comments left over from rebasing to 9.x from development
removed the git diff comments left over from rebasing to 9.x from development
removed a loose space in schema.rb
Also correct the pdf reading test
@DudeUnleashed
Copy link
Author

These are the related PRs for the thoth-tech repo
thoth-tech#43
thoth-tech#42
thoth-tech#41
thoth-tech#37
thoth-tech#36
thoth-tech#35
thoth-tech#34

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants