-
Notifications
You must be signed in to change notification settings - Fork 335
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feature/Courseflow-api #448
Open
DudeUnleashed
wants to merge
43
commits into
doubtfire-lms:new/course-flow
Choose a base branch
from
DudeUnleashed:courseflow
base: new/course-flow
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
feature/Courseflow-api #448
DudeUnleashed
wants to merge
43
commits into
doubtfire-lms:new/course-flow
from
DudeUnleashed:courseflow
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also correct the pdf reading test
Removed the git diff comments left over from rebasing to 9.x from development
removed the git diff comments left over from rebasing to 9.x from development
removed the git diff comments left over from rebasing to 9.x from development
removed the git diff comments left over from rebasing to 9.x from development
removed a loose space in schema.rb
…ated with appropriate new tests
Also correct the pdf reading test
merging broken branches
These are the related PRs for the thoth-tech repo |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR includes all the Courseflow API developed over t1 and t2 2024 as the feature branch. This implements the following API entities:
Course, Course Map, Course Map Unit, Unit Definition, Specialization, Requirement Set
Type of change
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
To test each endpoint you can use the following command, just modified for the specific filename, the below is the example
bundle exec rails test test/api/courseflow/course_api_test.rb
There are various rake commands added for generating testing data, they're under the courseflow_testing.rake file, key commands include
rake db:check_courseflow_data
rake db:populate_fixed_courseflow_data
Checklist:
If you have any questions, please contact @macite or @jakerenzella.