lisa: Remove matplotlib options for holoviews plots

BREAKING CHANGE Remove the matplotlib options for holoviews plot as that currently requires the matplotlib backend to be enabled just to validate the options. If and when this gets merged, this commit can be reverted: holoviz/holoviews#6196
douglas-raillard-arm · Apr 24, 2024 · 54b02e3 · 54b02e3
1 parent 2f558f4
commit 54b02e3
Show file tree

Hide file tree

Showing 5 changed files with 0 additions and 29 deletions.
diff --git a/lisa/analysis/cpus.py b/lisa/analysis/cpus.py
@@ -100,9 +100,6 @@ def plot_orig_capacity(self, cpu: CPU):
         return hv.HLine(
             orig_capacities[cpu],
             label='orig capacity'
-        ).options(
-            backend='matplotlib',
-            linestyle='--',
         ).options(
             backend='bokeh',
             line_dash='dashed',

diff --git a/lisa/analysis/latency.py b/lisa/analysis/latency.py
@@ -192,9 +192,6 @@ def _plot_threshold(self, y, **kwargs):
             **kwargs,
         ).options(
             color=self.LATENCY_THRESHOLD_COLOR
-        ).options(
-            backend='matplotlib',
-            linestyle='--',
         ).options(
             backend='bokeh',
             line_dash='dashed',
@@ -204,9 +201,6 @@ def _plot_markers(self, df, label):
         return hv.Scatter(df, label=label).options(marker='+').options(
             backend='bokeh',
             size=5,
-        ).options(
-            backend='matplotlib',
-            s=30,
         )
 
     def _plot_overutilized(self):

diff --git a/lisa/analysis/tasks.py b/lisa/analysis/tasks.py
@@ -1105,9 +1105,6 @@ def _plot_markers(self, df, label):
         return hv.Scatter(df, label=label).options(marker='+').options(
             backend='bokeh',
             size=5,
-        ).options(
-            backend='matplotlib',
-            s=30,
         )
 
     def _plot_overutilized(self):
@@ -1538,9 +1535,6 @@ def plot_rect(data):
                 show_legend=show_legend,
                 alpha=alpha,
                 **opts,
-            ).options(
-                backend='matplotlib',
-                linewidth=0,
             ).options(
                 backend='bokeh',
                 line_width=0,
@@ -1735,9 +1729,6 @@ def plot_tasks_activation(self, tasks: typing.Sequence[TaskID]=None, hide_tasks:
                 ).options(
                     backend='bokeh',
                     line_width=0.5,
-                ).options(
-                    backend='matplotlib',
-                    linewidth=0.5,
                 )
                 for y in range(trace.cpus_count + 1)
                 for offset in ((0.5, -0.5) if y == 0 else (0.5,))

diff --git a/lisa/notebook.py b/lisa/notebook.py
@@ -495,9 +495,6 @@ def _hv_twinx(fig, display=True, y_range=None):
     return fig.options(
         backend='bokeh',
         hooks=[_hv_backend_twinx('bokeh', **kwargs)],
-    ).options(
-        backend='matplotlib',
-        hooks=[_hv_backend_twinx('matplotlib', **kwargs)],
     )
 
 def _hv_multi_line_title_hook(plot, element):

diff --git a/lisa/stats.py b/lisa/stats.py
@@ -953,10 +953,6 @@ def plot_subdf(group, subdf):
         ).cols(ncols).options(
             backend='bokeh',
             toolbar='left',
-        ).options(
-            backend='matplotlib',
-            hspace=1.5,
-            vspace=0.7,
         ).options(
             # All plots are wrapped in an Overlay, either because they are true
             # overlays or because NdLayout needs to deal with a single element
@@ -1371,10 +1367,6 @@ def plot_func(df, group, x_col, y_col):
                     backend='bokeh',
                     marker='circle',
                     size=10,
-                ).options(
-                    backend='matplotlib',
-                    marker='o',
-                    s=100,
                 )
             )