This repository has been archived by the owner on Dec 31, 2019. It is now read-only.
Remove process.exit(0) from processEnding to fix false positives on CI server #113
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FYI, there were already 4 failing tests -- this patch didn't cause those.
Using
substack/tape
as an example, the test harness listens forprocess.exit
before printing results, and conditionally callingprocess.exit()
with a non zero exit code.I noticed that with a failing tests,
tape
does not even print the results because the exit routine is hijacked:At the moment, the
processEnding
function incover.js
causes the process to exit with an exit code of0
(as long as istanbul has no errors with coverage). As a consequence, the tests are assumed to have finished without error. This means that generating coverage on travis (or any other CI server) requires running the test suite twice unless you want to get false positives.Correct me if I'm wrong -- but removing this
process.exit()
call shouldn't affect any users unless their test suite hangs by itself.