Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added basic helix parsing for mmCIF #140

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

David-OConnor
Copy link

@David-OConnor David-OConnor commented Feb 17, 2025

Some notes:

  • No sheets yet (There are multiple sheet tables, and I'm not sure how to handle at this time)
  • I'm not sure how to correctly assign the start and end IDs based on chain. Maybe something to do with "label" vs "auth" ids? Or maybe the intent is to infer from the text fields. (mmCIF format issue; not code issue). The auth ids line up with the labels ("serial number") used elsewhere, but those are chain-specific... hence my concern.
  • Lots of repetition with the atom table parsing due to the way the macros are set up inside fns. I wasn't sure how to properly exfiltrate them to re-use.
  • No .PDB support
  • I didn't include AA information or length, but IMO it's redundant with the indices. (An overconstraint)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant