Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use dict_maps directly in configs #1047

Open
wants to merge 3 commits into
base: feature/config-rewrite
Choose a base branch
from
Open

Use dict_maps directly in configs #1047

wants to merge 3 commits into from
+121 −28

Conversation

sirainen
Copy link
Contributor

DOV-7076 kind of

@sirainen
config/shared_mailboxes: Use dict_maps directly instead of going thro…
a786056 
…ugh dovecot-dict-sql.conf.inc

There are only two maps, so seems unnecessarily complicated to add an
external file for it.
@sirainen
quota_clone: Use dict_maps directly instead of pointing to an externa…
c42fbbf 
…l file

The external file wasn't even described in the documentation.
@sirainen sirainen added the config-rewrite Issues associated with config rewrite label Oct 10, 2024
sirainen
sirainen commented Oct 24, 2024
View reviewed changes
docs/core/recommended_metrics.md
---
layout: doc
title: Recommended Metrics
order: 101
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This possibly should have dovecotlinks, which are now in palomar recommended_metrics page. But unless this page is somehow disabled, the links can't be the same.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If I understand you correctly there are two options:

  1. rename the palomar page's recommended settings links,
  2. prefix this here links with global_ or something to differentiate them from the palomar ones.

I suggest version 1 as these links don't seem to have been referenced anywhere.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fleischie fleischie fleischie approved these changes

Assignees
No one assigned
Labels
config-rewrite Issues associated with config rewrite
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sirainen @fleischie