remove to_ary delegation WIP #70
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidbl
force-pushed
the
169395632_remove_to_ary
branch
from
bd7f1e8 to
b91993f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PT story https://www.pivotaltracker.com/story/show/169371020
Overview
Initial work for the v7.2 upgrade was done under #69
But that version caused some errors in downstream users of the gem. The source of those errors was traced to the delegation of
to_aryinLazySearchclass. That delegation seemed to be serving no purpose that I could find so I have removed it.see https://github.com/doximity/doximity/pull/30869