Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement tools tab #326

Merged
merged 4 commits into from
Feb 7, 2025
Merged

Implement tools tab #326

merged 4 commits into from
Feb 7, 2025

Conversation

cmil
Copy link
Member

@cmil cmil commented Jan 31, 2025

Here is a first basic implementation of the tools tab.

resolve #310

@cmil cmil self-assigned this Jan 31, 2025
@cmil
Copy link
Member Author

cmil commented Jan 31, 2025

@ingoboerner @lehkost This is now deployed on dev: https://dev.dracor.org/ger/lessing-emilia-galotti#tools. Please have a look.

If @markschwindt has time, he could definitely spice it up a bit visually.

@cmil cmil requested review from lehkost and ingoboerner January 31, 2025 16:24
@cmil cmil added this to the 2.4.0 milestone Jan 31, 2025
@lehkost
Copy link
Member

lehkost commented Feb 2, 2025

Voyant works really well. I also tried some tools of the Switchboard, all worked as they should. Really cool stuff.

About the wording, I would use the official variant "CLARIN Language Resource Switchboard".

Instead of "Text to analyze" I would put: "Text layer for analysis".

As tool description in the right sidebar I suggest: "This tab provides links to third-party tools. The selected text layer is forwarded directly for external analysis."

cmil added a commit that referenced this pull request Feb 2, 2025
@cmil
Copy link
Member Author

cmil commented Feb 2, 2025

About the wording, I would use the official variant "CLARIN Language Resource Switchboard".

Instead of "Text to analyze" I would put: "Text layer for analysis".

As tool description in the right sidebar I suggest: "This tab provides links to third-party tools. The selected text layer is forwarded directly for external analysis."

I adjusted the wording. I slightly changed the sidebar description since the texts are not exactly forwarded. This is also why the tab will not work in a local environment, because the external tools cannot access a local API instance. In that case a note explaining this is displayed instead of the links.

cmil added a commit that referenced this pull request Feb 2, 2025
@ingoboerner
Copy link
Contributor

Cool! I just looked at the tools tab. The timing is perfect for the presentation at the CLARIN Strategy Days the day after tomorrow ;) Thanks for that!

Currently we can not load the whole text of a drama, right? See also dracor-org/dracor-api#281

@cmil
Copy link
Member Author

cmil commented Feb 6, 2025

@ingoboerner For now we can use the full TEI with both Voyant and the CLARIN Switchboard. The latter then only provides a reduced selection of tools, but that's better than nothing. See the updated version on https://dev.dracor.org/ger/lessing-emilia-galotti#tools.

Once we have an endpoint for the full plain text we can add that too.

@ingoboerner
Copy link
Contributor

Cool, thanks for looking that up. That is exactly what CLARIN people told me today. Using the Switchboard, I was told, is promised to be a sustainable approach to get access to CLARINs tool, so thanks for implementing it!

@lehkost
Copy link
Member

lehkost commented Feb 6, 2025

Very cool addition, thanks! Maybe instead of "TEI" next to the radio button, we could detail it as "Full text (TEI-encoded)" – that would correspond to the wording in the Downloads tab.

@cmil cmil merged commit 8174868 into main Feb 7, 2025
@cmil cmil deleted the 310-tools-tab branch February 7, 2025 22:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add links to external tools [was: Add links to voyant tools]
3 participants