Turn theme into Preference Pack #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Awesome work here. Thanks @Chrismettal ! |
|
testers, please report issues? We're waiting upstream for this PR to be merged |
|
Bumping |
|
Great work @Chrismettal, thanks for the PR! Just one thing, can you leave the original instructions in |
|
Also if you'd like to @Chrismettal, feel free to add yourself to the "Team" section in |
Good call, didn't think about that!
Gladly! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See related issue: #2
Refactors the repo into easily installable PreferencePack, supported by FreeCAD version 0.20 and up.
Allows easier installation without overwriting/merging the user.cfg manually. After installing the PreferencePack to your FreeCAD installation, theme can be applied with one click in settings.
Installation instructions were also updated accordingly.
I will open up a PR to the addon manager repo, adding this PreferencePack there, so it can be installed from within FreeCAD, without manually downloading/installing anything. This is already referenced in the installation manual.
I have taken the liberty to create an SVG Icon showing representative colors for the addon manager, similar to existing PreferencePacks to help users to get a glance of themes when scrolling through the addon manager.
Additionaly, the "Fully constrained" color in the sketcher was still set to default, and has been set to the green defined in the Dracula palette.