fix: less transparency #17
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Other thing I noticed, when there's no tab open it's also fully transparent. I tried to |
|
Further, I'll say making just these changes is probably not good enough, because upon using it for a couple more hours I see that it does look a little weird. Maybe someone that understands about Dracula themes could make better changes and make this PR in the correct way, so I'll close it for now and keep my eyes peeled on the mentioned issue. Sorry for the confusion! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm trying zed on linux (yay!) and immediately went for Dracula.
I was a little confused about the transparency and the issue #16 made me thing it was not intentional.
I made some local changes locally in order to keep exploring, but I have no idea if they are (1) correct (2) complete and especially if (3) they don't cause any side effects for other configurations.
I'm opening this PR just to share that these improved my situation and might help someone else.
I'd love to see this fixed upstream by an experienced maintainer :D