Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(mksh): implicit install requires printf #2362

Closed
wants to merge 1 commit into from

Conversation

FGrose
Copy link
Contributor

@FGrose FGrose commented May 22, 2023

Check for and install printf, when missing, and mksh is /bin/sh.

When these conditions apply,

  1. host has ln -sf mksh /bin/sh, and
  2. if a shell program is NOT specified, and
  3. if NO modules are called with a dependency for the 99base module (where bash would be specified), then

resolve_deps() will install mksh, as the source for /bin/sh as in Script installs with a shebang.

Checklist

  • [✔] I have tested it locally

Fixes #1530; finishes #1534.

Check for and install printf when missing and mksh is /bin/sh.
@LaszloGombos
Copy link
Collaborator

@FGrose Can you think of a solution to move the fix out of dracut.sh into mksh dracut module instead ?

@FGrose
Copy link
Contributor Author

FGrose commented May 28, 2023

@FGrose > Can you think of a solution to move the fix out of dracut.sh into mksh dracut module instead ?
@LaszloGombos
Superseded by #2368.

@FGrose FGrose closed this May 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

printf not installed
2 participants