Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(rngd): install system service file #2442

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

pvalena
Copy link
Contributor

@pvalena pvalena commented Jul 23, 2023

as there's no reason to keep a copy; there shouldn't be any modifications.

Downstream bug: https://bugzilla.redhat.com/show_bug.cgi?id=2181541

Changes

Install system rngd.service file instead of a custom (bundled) one.

Checklist

  • I have tested it locally
  • I have reviewed and updated any documentation if relevant
  • I am providing new code and test(s) for it

@github-actions github-actions bot added modules Issue tracker for all modules rngd Issues related to the rngd module labels Jul 23, 2023
Copy link
Collaborator

@LaszloGombos LaszloGombos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. Thanks

Copy link
Member

@aafeijoo-suse aafeijoo-suse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The service shipped with rng-tools is not ordered Before=systemd-udevd.service and has a install section with WantedBy=multi-user.target. Are you sure this change works?

CC: @rmetrich

@pvalena
Copy link
Contributor Author

pvalena commented Jul 24, 2023

The service shipped with rng-tools is not ordered Before=systemd-udevd.service and has a install section with WantedBy=multi-user.target. Are you sure this change works?

CC: @rmetrich

Thanks for checking, let me test various systems.

@pvalena pvalena marked this pull request as draft July 24, 2023 09:12
@pvalena
Copy link
Contributor Author

pvalena commented Jul 24, 2023

FTR this does not work atm. as /etc/sysconfig/rngd is not installed.

@aafeijoo-suse
Copy link
Member

FTR this does not work atm. as /etc/sysconfig/rngd is not installed.

Is that RH specific? https://github.com/nhorman/rng-tools/blob/master/rngd.service

@pvalena pvalena force-pushed the copy-rngd-service-file branch 3 times, most recently from dc7ecb4 to 4be439e Compare July 24, 2023 09:41
@pvalena
Copy link
Contributor Author

pvalena commented Jul 24, 2023

FTR this does not work atm. as /etc/sysconfig/rngd is not installed.

Is that RH specific? https://github.com/nhorman/rng-tools/blob/master/rngd.service

Unfortunately, yes, it seems we ship it https://src.fedoraproject.org/rpms/rng-tools/blob/rawhide/f/rngd.service | https://gitlab.com/redhat/centos-stream/rpms/rng-tools/-/blob/c9s/rngd.service

@pvalena
Copy link
Contributor Author

pvalena commented Jul 24, 2023

(Sorry about all of those pushes; I somehow thought I'd resolve it without testing first.)

@pvalena
Copy link
Contributor Author

pvalena commented Jul 24, 2023

@pvalena pvalena marked this pull request as ready for review July 24, 2023 10:21
@pvalena
Copy link
Contributor Author

pvalena commented Jul 24, 2023

Added to commit message:

    In case there are args stored in a separate file (Fedora and alike),
    it needs to be supplied too, but without the option to change the user.

as there's no reason to keep a copy; there shouldn't be any modifications.

In case there are args stored in a separate file (Fedora and alike),
it needs to be supplied too, but without the option to change the user.
@stale
Copy link

stale bot commented Sep 16, 2023

This issue is being marked as stale because it has not had any recent activity. It will be closed if no further activity occurs. If this is still an issue in the latest release of Dracut and you would like to keep it open please comment on this issue within the next 7 days. Thank you for your contributions.

@stale stale bot added the stale communication is stuck label Sep 16, 2023
@pvalena
Copy link
Contributor Author

pvalena commented Sep 20, 2023

This is still pending merge.

@stale stale bot removed the stale communication is stuck label Sep 20, 2023
@LaszloGombos LaszloGombos added this to the dracut-061 milestone Nov 1, 2023
@aafeijoo-suse aafeijoo-suse removed this from the dracut-061 milestone Nov 18, 2023
Copy link

stale bot commented Apr 22, 2024

This issue is being marked as stale because it has not had any recent activity. It will be closed if no further activity occurs. If this is still an issue in the latest release of Dracut and you would like to keep it open please comment on this issue within the next 7 days. Thank you for your contributions.

@stale stale bot added the stale communication is stuck label Apr 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
modules Issue tracker for all modules rngd Issues related to the rngd module stale communication is stuck
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants