-
Notifications
You must be signed in to change notification settings - Fork 400
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: change the order of lint jobs as lint_shell is more likely to fail #2447
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great find. Thanks.
Next time please consolidate your comments into the main PR message to help reviewers to understand what are you trying to solve.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe this approach is fine, but AFAIK we were able to identify an entry with Lint / lint-shell
so far, the problem is that both Lint entries are not ordered in the checklist.
Can not land for the same reason as Need to look into alternatives to help with the reviews and make the failure more obvious for other contributors who do not contribute to dracut regularly... |
0194571
to
e526be4
Compare
I think I was wrong. Both job failures are reported without changing the code. It is just hard to find the failure for lint-shell as it is usually at the bottom. @LaszloGombos What should I do now ? Should I close this PR ? |
@Henrik66 For the goal of making lint-shell test result more easy to find (and run it earlier) perhaps we can at least change the order the test run. What do you think ? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @Henrik66 .
@aafeijoo-suse are you still ok with this changed PR to land ?
ci: change the order of lint jobs as lint_shell is more likely to fail..
Now the lint_shell test result is "above the scroll" on the page.