Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(dmsquash-live): use the overlay size with thin provisioning #2604

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

gregory-lee-bartholomew
Copy link

Using the overlay size in the device mapper table allows the filesystem in the base image to be extended at runtime if the overlay is larger than the base image (i.e. this makes resize2fs /dev/mapper/live-rw work when rd.live.overlay.thin is used).

This pull request changes...

Changes

This patch changes the upper-bound of the live-rw device when the user requests to create a thin-provisioned overlay by specifying the rd.live.overlay.thin kernel parameter. The size of the overlay (typically 32GiB, but it can be specified by the user with a kernel parameter) is used rather than the size of the base image.

Checklist

  • I have tested it locally
  • I have reviewed and updated any documentation if relevant
  • I am providing new code and test(s) for it

Fixes #

Users of Fedora Linux have been reporting this bug here: https://discussion.fedoraproject.org/t/fedora-liveos-root-system-and-available-ram/82531/1

Using the overlay size in the device mapper table allows the filesystem in the base image to be extended if the overlay is larger than the base image (e.g. `resize2fs /dev/mapper/live-rw`).
@github-actions github-actions bot added modules Issue tracker for all modules dmsquash-live Issues related to the dmsquash-live module labels Jan 9, 2024
@LaszloGombos
Copy link
Collaborator

CC @FGrose

Copy link

stale bot commented Mar 13, 2024

This issue is being marked as stale because it has not had any recent activity. It will be closed if no further activity occurs. If this is still an issue in the latest release of Dracut and you would like to keep it open please comment on this issue within the next 7 days. Thank you for your contributions.

@stale stale bot added the stale communication is stuck label Mar 13, 2024
@LaszloGombos LaszloGombos added this to the dracut-060 milestone Mar 14, 2024
@stale stale bot removed the stale communication is stuck label Mar 14, 2024
@LaszloGombos LaszloGombos removed this from the dracut-060 milestone Mar 14, 2024
@gregory-lee-bartholomew
Copy link
Author

Thanks @Conan-Kudo. I'll close this MR since the change has been merged in another MR. 🙂

@gregory-lee-bartholomew
Copy link
Author

gregory-lee-bartholomew commented Apr 7, 2024

I think I may have closed this prematurely. I see now that what was merged earlier was to "dracut-ng", not "dracut". I'll reopen this against "dracut" and I'll fix the commit message to be consistent with the one that was merged earlier. Sorry about the confusion.

@gregory-lee-bartholomew gregory-lee-bartholomew changed the title with thin provisioning, use the overlay size, not the base image size fix(dmsquash-live): use the overlay size with thin provisioning Apr 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dmsquash-live Issues related to the dmsquash-live module modules Issue tracker for all modules
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants