fix: properly set ttl bit during object replacement #3991
Merged
+24
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fixes #3984 Signed-off-by: Roman Gershman <[email protected]>
kostasrim
approved these changes
Oct 24, 2024
There was a problem hiding this comment.
I understand we did not properly set the ttl bit but how does this cause the crash mentioned in the issue ? ObjExpireTime will return UINT32_MAX. That merely affects the expiry time and ReallocIfNeeded (the second might have been problematic but it doesn't matter it is fixed now).
Why setting the ttl bit will cause issues since it will be ignored anyway ? (Ignore meaning that we always promt for the ttl but on wrapper)
|
@kostasrim |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #3984