Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(search_family): Add options test for the FT.SEARCH command #4478

Merged
merged 1 commit into from
Jan 30, 2025
Merged

fix(search_family): Add options test for the FT.SEARCH command #4478

merged 1 commit into from
Jan 30, 2025

Conversation

BagritsevichStepan
Copy link
Contributor

@BagritsevichStepan BagritsevichStepan commented Jan 20, 2025 •
edited
Loading

related to the #4204

After adding the tests, several bugs were identified:

  1. Bug with the NOCONTENT option.
  2. An infinite loop occurring during the parsing of RETURN and LOAD options if the specified number of fields is big

@BagritsevichStepan BagritsevichStepan self-assigned this Jan 20, 2025
@BagritsevichStepan BagritsevichStepan mentioned this pull request Jan 19, 2025
Open
5 tasks
@BagritsevichStepan BagritsevichStepan force-pushed the search/ft-search-add-option-tests branch from 1a31eef to 3592e33 Compare January 30, 2025 08:57
@BagritsevichStepan BagritsevichStepan enabled auto-merge (squash) January 30, 2025 08:57
@BagritsevichStepan BagritsevichStepan merged commit 83569ac into dragonflydb:main Jan 30, 2025
10 checks passed
@BagritsevichStepan BagritsevichStepan deleted the search/ft-search-add-option-tests branch January 30, 2025 12:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BorysTheDev BorysTheDev BorysTheDev approved these changes

Assignees

@BagritsevichStepan BagritsevichStepan

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@BagritsevichStepan @BorysTheDev