chore: refactoring around glob matching #4540
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. Make GlobMatcher non-copyable. It's something I will need in the next PR. 2. Move low-level benchmarking testing code into dfly_core_test. No functional changes. Signed-off-by: Roman Gershman <[email protected]>
romange
commented
Jan 31, 2025
| EXPECT_EQ(MatchLen("[$?^]a", "?a", 0), 1); | ||
| } | ||
|
|
||
| using benchmark::DoNotOptimize; |
There was a problem hiding this comment.
moved from dragonfly_test.
kostasrim
approved these changes
Jan 31, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No functional changes.